Skip to content

Commit

Permalink
fix(repo): fix failing e2e tests
Browse files Browse the repository at this point in the history
  • Loading branch information
jaysoo authored and Jack Hsu committed Dec 15, 2022
1 parent 622070b commit 54dcb62
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion e2e/jest/src/jest-root.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ describe('Jest root projects', () => {
}, 300_000);

it('should add lib project and tests should still work', async () => {
runCLI(`generate @nrwl/react:lib ${mylib}`);
runCLI(`generate @nrwl/react:lib ${mylib} --unitTestRunner=jest`);

const libProjectTestResults = await runCLIAsync(`test ${mylib}`);

Expand Down
2 changes: 1 addition & 1 deletion e2e/linter/src/linter.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -473,7 +473,7 @@ export function tslibC(): string {
'plugin:@nrwl/nx/javascript',
]);

runCLI(`generate @nrwl/react:lib ${mylib}`);
runCLI(`generate @nrwl/react:lib ${mylib} --unitTestRunner=jest`);
// should add new tslint
expect(() => checkFilesExist(`.eslintrc.base.json`)).not.toThrow();
const appEslint = readJson(`.eslintrc.json`);
Expand Down
2 changes: 1 addition & 1 deletion e2e/web/src/web.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ describe('Web Components Applications', () => {
`generate @nrwl/web:app ${appName} --bundler=webpack --no-interactive --compiler swc`
);
runCLI(
`generate @nrwl/react:lib ${libName} --bundler=rollup --no-interactive --compiler swc`
`generate @nrwl/react:lib ${libName} --bundler=rollup --no-interactive --compiler swc --unitTestRunner=jest`
);

createFile(`dist/apps/${appName}/_should_remove.txt`);
Expand Down

0 comments on commit 54dcb62

Please sign in to comment.