Skip to content

Commit

Permalink
fix(angular): use @nrwl/web:file-server (#15849)
Browse files Browse the repository at this point in the history
  • Loading branch information
Coly010 committed Mar 27, 2023
1 parent 78fb3b9 commit 597832e
Show file tree
Hide file tree
Showing 18 changed files with 161 additions and 365 deletions.
8 changes: 0 additions & 8 deletions docs/generated/manifests/menus.json
Original file line number Diff line number Diff line change
Expand Up @@ -3602,14 +3602,6 @@
"isExternal": false,
"disableCollapsible": false
},
{
"id": "file-server",
"path": "/packages/angular/executors/file-server",
"name": "file-server",
"children": [],
"isExternal": false,
"disableCollapsible": false
},
{
"id": "webpack-browser",
"path": "/packages/angular/executors/webpack-browser",
Expand Down
9 changes: 0 additions & 9 deletions docs/generated/manifests/packages.json
Original file line number Diff line number Diff line change
Expand Up @@ -70,15 +70,6 @@
"path": "/packages/angular/executors/package",
"type": "executor"
},
"/packages/angular/executors/file-server": {
"description": "Serves a static web application from a folder.",
"file": "generated/packages/angular/executors/file-server.json",
"hidden": false,
"name": "file-server",
"originalFilePath": "/packages/angular/src/executors/file-server/schema.json",
"path": "/packages/angular/executors/file-server",
"type": "executor"
},
"/packages/angular/executors/webpack-browser": {
"description": "The `webpack-browser` executor is very similar to the standard `browser` builder provided by the Angular Devkit. It allows you to build your Angular application to a build artifact that can be hosted online. There are some key differences: \n- Supports Custom Webpack Configurations \n- Supports Incremental Building",
"file": "generated/packages/angular/executors/webpack-browser.json",
Expand Down
9 changes: 0 additions & 9 deletions docs/generated/packages-metadata.json
Original file line number Diff line number Diff line change
Expand Up @@ -64,15 +64,6 @@
"path": "angular/executors/package",
"type": "executor"
},
{
"description": "Serves a static web application from a folder.",
"file": "generated/packages/angular/executors/file-server.json",
"hidden": false,
"name": "file-server",
"originalFilePath": "/packages/angular/src/executors/file-server/schema.json",
"path": "angular/executors/file-server",
"type": "executor"
},
{
"description": "The `webpack-browser` executor is very similar to the standard `browser` builder provided by the Angular Devkit. It allows you to build your Angular application to a build artifact that can be hosted online. There are some key differences: \n- Supports Custom Webpack Configurations \n- Supports Incremental Building",
"file": "generated/packages/angular/executors/webpack-browser.json",
Expand Down
5 changes: 5 additions & 0 deletions docs/generated/packages/web/executors/file-server.json
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,11 @@
"staticFilePath": {
"type": "string",
"description": "Path where the build artifacts are located. If not provided then it will be infered from the buildTarget executor options as outputPath"
},
"cors": {
"type": "boolean",
"description": "Enable CORS",
"default": true
}
},
"additionalProperties": false,
Expand Down
4 changes: 0 additions & 4 deletions nx-dev/nx-dev-e2e/src/e2e/packages.cy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -96,10 +96,6 @@ describe('nx-dev: Packages Section', () => {
title: '@nrwl/angular:package',
path: '/packages/angular/executors/package',
},
{
title: '@nrwl/angular:file-server',
path: '/packages/angular/executors/file-server',
},
{ title: 'cra-to-nx', path: '/packages/cra-to-nx' },
{ title: 'create-nx-plugin', path: '/packages/create-nx-plugin' },
{
Expand Down
10 changes: 0 additions & 10 deletions packages/angular/executors.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,6 @@
"implementation": "./src/executors/package/package.impl",
"schema": "./src/executors/package/schema.json",
"description": "Builds and packages an Angular library producing an output following the Angular Package Format (APF) to be distributed as an NPM package.\nThis executor is similar to the `@angular-devkit/build-angular:ng-packagr` with additional support for incremental builds."
},
"file-server": {
"implementation": "./src/executors/file-server/file-server.impl",
"schema": "./src/executors/file-server/schema.json",
"description": "Serves a static web application from a folder."
}
},
"builders": {
Expand Down Expand Up @@ -61,11 +56,6 @@
"implementation": "./src/builders/module-federation-dev-ssr/module-federation-dev-ssr.impl",
"schema": "./src/builders/module-federation-dev-ssr/schema.json",
"description": "The module-federation-dev-ssr executor is reserved exclusively for use with host Module Federation applications that use SSR. It allows the user to specify which remote applications should be served with the host."
},
"file-server": {
"implementation": "./src/executors/file-server/compat",
"schema": "./src/executors/file-server/schema.json",
"description": "Serve a web application from a folder."
}
}
}
6 changes: 6 additions & 0 deletions packages/angular/migrations.json
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,12 @@
"version": "15.9.0-beta.3",
"description": "Update the tsconfig.spec.json to use target es2016 for jest-preset-angular v13",
"factory": "./src/migrations/update-15-9-0/update-testing-tsconfig"
},
"update-file-server-executor": {
"cli": "nx",
"version": "15.9.0-beta.9",
"description": "Update the file-server executor to use @nrwl/web:file-server",
"factory": "./src/migrations/update-15-9-0/update-file-server-executor"
}
},
"packageJsonUpdates": {
Expand Down
5 changes: 0 additions & 5 deletions packages/angular/src/executors/file-server/compat.ts

This file was deleted.

221 changes: 0 additions & 221 deletions packages/angular/src/executors/file-server/file-server.impl.ts

This file was deleted.

16 changes: 0 additions & 16 deletions packages/angular/src/executors/file-server/schema.d.ts

This file was deleted.

1 comment on commit 597832e

@vercel
Copy link

@vercel vercel bot commented on 597832e Mar 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

nx-dev – ./

nx-five.vercel.app
nx-dev-nrwl.vercel.app
nx-dev-git-master-nrwl.vercel.app
nx.dev

Please sign in to comment.