Skip to content

Commit

Permalink
cleanup(angular): remove devkit schematics from ensured package (#15902)
Browse files Browse the repository at this point in the history
  • Loading branch information
Coly010 committed Mar 29, 2023
1 parent afdf5ea commit 6221cda
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 6 deletions.
6 changes: 2 additions & 4 deletions packages/angular/src/generators/init/init.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,7 @@ export async function angularInitGenerator(

const pkgVersions = versions(tree);

const peerDepsToInstall = [
'@angular-devkit/core',
'@angular-devkit/schematics',
];
const peerDepsToInstall = ['@angular-devkit/core'];
let devkitVersion: string;
peerDepsToInstall.forEach((pkg) => {
const packageVersion = getInstalledPackageVersion(tree, pkg);
Expand Down Expand Up @@ -162,6 +159,7 @@ function updateDependencies(
'@angular/compiler-cli': angularVersion,
'@angular/language-service': angularVersion,
'@angular-devkit/build-angular': angularDevkitVersion,
'@angular-devkit/schematics': angularDevkitVersion,
'@schematics/angular': angularDevkitVersion,
}
);
Expand Down
1 change: 0 additions & 1 deletion packages/workspace/src/generators/new/generate-preset.ts
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,6 @@ function getPresetDependencies({
dependencies: { '@nrwl/angular': nxVersion },
dev: {
'@angular-devkit/core': angularCliVersion,
'@angular-devkit/schematics': angularCliVersion,
typescript: typescriptVersion,
},
};
Expand Down
1 change: 0 additions & 1 deletion packages/workspace/src/generators/new/new.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,6 @@ describe('new', () => {
expect(dependencies).toStrictEqual({ '@nrwl/angular': nxVersion });
expect(devDependencies).toStrictEqual({
'@angular-devkit/core': angularCliVersion,
'@angular-devkit/schematics': angularCliVersion,
'@nrwl/workspace': nxVersion,
nx: nxVersion,
typescript: typescriptVersion,
Expand Down

1 comment on commit 6221cda

@vercel
Copy link

@vercel vercel bot commented on 6221cda Mar 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

nx-dev – ./

nx-five.vercel.app
nx-dev-git-master-nrwl.vercel.app
nx.dev
nx-dev-nrwl.vercel.app

Please sign in to comment.