fix(testing): check if target exists before adding target for jest (#…

…18327)
nrwl · Aug 2, 2023 · 697754d · 697754d · vercel · Aug 2, 2023
1 parent e5fd0d5
commit 697754d
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/packages/jest/src/generators/configuration/configuration.spec.ts b/packages/jest/src/generators/configuration/configuration.spec.ts
@@ -3,6 +3,7 @@ import {
   readJson,
   readProjectConfiguration,
   Tree,
+  updateProjectConfiguration,
   writeJson,
 } from '@nx/devkit';
 import { createTreeWithEmptyWorkspace } from '@nx/devkit/testing';
@@ -60,6 +61,19 @@ describe('jestProject', () => {
     expect(tree.read('libs/lib1/jest.config.ts', 'utf-8')).toMatchSnapshot();
   });
 
+  it('should add target if there are no targets', async () => {
+    const pc = readProjectConfiguration(tree, 'lib1');
+    delete pc.targets;
+    updateProjectConfiguration(tree, 'lib1', pc);
+    expect(async () => {
+      await configurationGenerator(tree, {
+        ...defaultOptions,
+        project: 'lib1',
+        setupFile: 'angular',
+      });
+    }).not.toThrow();
+  });
+
   it('should alter project configuration', async () => {
     await configurationGenerator(tree, {
       ...defaultOptions,

diff --git a/packages/jest/src/generators/configuration/lib/update-workspace.ts b/packages/jest/src/generators/configuration/lib/update-workspace.ts
@@ -12,6 +12,10 @@ export function updateWorkspace(
   options: NormalizedJestProjectSchema
 ) {
   const projectConfig = readProjectConfiguration(tree, options.project);
+  if (!projectConfig.targets) {
+    projectConfig.targets = {};
+  }
+
   projectConfig.targets.test = {
     executor: '@nx/jest:jest',
     outputs: [