Skip to content

Commit

Permalink
fix(core): use name instead of .prototype.name when comparing errors (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
MaxKless committed Apr 16, 2024
1 parent 714ea48 commit 71023c8
Showing 1 changed file with 3 additions and 7 deletions.
10 changes: 3 additions & 7 deletions packages/nx/src/project-graph/error-types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -132,9 +132,7 @@ export class MergeNodesError extends Error {
export function isCreateNodesError(e: unknown): e is CreateNodesError {
return (
e instanceof CreateNodesError ||
(typeof e === 'object' &&
'name' in e &&
e?.name === CreateNodesError.prototype.name)
(typeof e === 'object' && 'name' in e && e?.name === CreateNodesError.name)
);
}

Expand All @@ -145,15 +143,13 @@ export function isAggregateCreateNodesError(
e instanceof AggregateCreateNodesError ||
(typeof e === 'object' &&
'name' in e &&
e?.name === AggregateCreateNodesError.prototype.name)
e?.name === AggregateCreateNodesError.name)
);
}

export function isMergeNodesError(e: unknown): e is MergeNodesError {
return (
e instanceof MergeNodesError ||
(typeof e === 'object' &&
'name' in e &&
e?.name === MergeNodesError.prototype.name)
(typeof e === 'object' && 'name' in e && e?.name === MergeNodesError.name)
);
}

0 comments on commit 71023c8

Please sign in to comment.