Skip to content

Commit

Permalink
feat(misc): make add-nx-to-monorepo interactive
Browse files Browse the repository at this point in the history
  • Loading branch information
vsavkin committed Oct 7, 2022
1 parent 35ad732 commit 7fabc85
Show file tree
Hide file tree
Showing 4 changed files with 164 additions and 210 deletions.
16 changes: 2 additions & 14 deletions e2e/add-nx-to-monorepo/src/add-nx-to-monorepo.test.ts
Expand Up @@ -42,19 +42,10 @@ describe('add-nx-to-monorepo', () => {

// Act
const output = runCommand(
`${packageManagerCommand} add-nx-to-monorepo@${getPublishedVersion()} --nx-cloud false`
`${packageManagerCommand} add-nx-to-monorepo@${getPublishedVersion()} -y`
);
// Assert
expect(output).toContain('🎉 Done!');
expect(readWorkspaceConfig().projects['package-a']).toBeTruthy();
expect(readWorkspaceConfig().projects['package-b']).toBeTruthy();
expect(readWorkspaceConfig().targetDefaults).toEqual({
build: { dependsOn: ['^build'] },
});
expect(
readWorkspaceConfig().tasksRunnerOptions['default'].options
.cacheableOperations
).toEqual(['build', 'test', 'lint']);
}
});

Expand All @@ -74,14 +65,11 @@ describe('add-nx-to-monorepo', () => {

// Act
runCommand(
`${packageManagerCommand} add-nx-to-monorepo@${getPublishedVersion()} --nx-cloud false`
`${packageManagerCommand} add-nx-to-monorepo@${getPublishedVersion()} -y`
);
const output = runCLI('build package-a');
// Assert
expect(output).toContain('build successful');
}
});
});

const readWorkspaceConfig = () =>
new Workspaces(tmpProjPath()).readWorkspaceConfiguration();
5 changes: 2 additions & 3 deletions e2e/nx-init/src/nx-init.test.ts
Expand Up @@ -28,9 +28,8 @@ describe('nx init', () => {
})
);

const output = runCommand(`${packageManagerCommand} nx init`);
expect(output).toContain('Nx has been installed');
expect(output).toContain('nx.json has been created');
const output = runCommand(`${packageManagerCommand} nx init -y`);
expect(output).toContain('Done!');

expect(runCLI('run package:echo')).toContain('123');
renameFile('nx.json', 'nx.json.old');
Expand Down

1 comment on commit 7fabc85

@vercel
Copy link

@vercel vercel bot commented on 7fabc85 Oct 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

nx-dev – ./

nx-dev-git-master-nrwl.vercel.app
nx-five.vercel.app
nx-dev-nrwl.vercel.app
nx.dev

Please sign in to comment.