Skip to content

Commit

Permalink
fix(angular): amend wrong project name schema options to hint nx cons…
Browse files Browse the repository at this point in the history
…ole to show a project dropdown (#11097)
  • Loading branch information
leosvelperez committed Jul 11, 2022
1 parent 4a3a223 commit 9352f2e
Show file tree
Hide file tree
Showing 6 changed files with 24 additions and 10 deletions.
15 changes: 10 additions & 5 deletions docs/generated/packages/angular.json
Original file line number Diff line number Diff line change
Expand Up @@ -906,7 +906,8 @@
"type": "string",
"description": "The name of the library to create the secondary entry point for.",
"x-prompt": "What library would you like to create the secondary entry point for?",
"pattern": "^[a-zA-Z].*$"
"pattern": "^[a-zA-Z].*$",
"$default": { "$source": "projectName" }
},
"skipModule": {
"type": "boolean",
Expand Down Expand Up @@ -948,7 +949,8 @@
},
"host": {
"type": "string",
"description": "The name of the host app to attach this remote app to."
"description": "The name of the host app to attach this remote app to.",
"$default": { "$source": "projectName" }
},
"port": {
"type": "number",
Expand Down Expand Up @@ -1750,7 +1752,8 @@
"type": "string",
"description": "The name of the application to generate the Module Federation configuration for.",
"$default": { "$source": "argv", "index": 0 },
"x-prompt": "What app would you like to generate a Module Federation configuration for?"
"x-prompt": "What app would you like to generate a Module Federation configuration for?",
"x-dropdown": "projects"
},
"mfType": {
"type": "string",
Expand Down Expand Up @@ -1869,7 +1872,8 @@
"type": "string",
"description": "The name of the project.",
"$default": { "$source": "argv", "index": 0 },
"x-prompt": "What's the name of the project for which you want to generate stories?"
"x-prompt": "What's the name of the project for which you want to generate stories?",
"x-dropdown": "projects"
},
"generateCypressSpecs": {
"type": "boolean",
Expand Down Expand Up @@ -1910,7 +1914,8 @@
"name": {
"type": "string",
"description": "The name of the project.",
"$default": { "$source": "argv", "index": 0 }
"$default": { "$source": "argv", "index": 0 },
"x-dropdown": "projects"
},
"configureCypress": {
"type": "boolean",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,10 @@
"type": "string",
"description": "The name of the library to create the secondary entry point for.",
"x-prompt": "What library would you like to create the secondary entry point for?",
"pattern": "^[a-zA-Z].*$"
"pattern": "^[a-zA-Z].*$",
"$default": {
"$source": "projectName"
}
},
"skipModule": {
"type": "boolean",
Expand Down
5 changes: 4 additions & 1 deletion packages/angular/src/generators/remote/schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,10 @@
},
"host": {
"type": "string",
"description": "The name of the host app to attach this remote app to."
"description": "The name of the host app to attach this remote app to.",
"$default": {
"$source": "projectName"
}
},
"port": {
"type": "number",
Expand Down
3 changes: 2 additions & 1 deletion packages/angular/src/generators/setup-mf/schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@
"$source": "argv",
"index": 0
},
"x-prompt": "What app would you like to generate a Module Federation configuration for?"
"x-prompt": "What app would you like to generate a Module Federation configuration for?",
"x-dropdown": "projects"
},
"mfType": {
"type": "string",
Expand Down
3 changes: 2 additions & 1 deletion packages/angular/src/generators/stories/schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@
"$source": "argv",
"index": 0
},
"x-prompt": "What's the name of the project for which you want to generate stories?"
"x-prompt": "What's the name of the project for which you want to generate stories?",
"x-dropdown": "projects"
},
"generateCypressSpecs": {
"type": "boolean",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@
"$default": {
"$source": "argv",
"index": 0
}
},
"x-dropdown": "projects"
},
"configureCypress": {
"type": "boolean",
Expand Down

1 comment on commit 9352f2e

@vercel
Copy link

@vercel vercel bot commented on 9352f2e Jul 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

nx-dev – ./

nx-dev-nrwl.vercel.app
nx-five.vercel.app
nx-dev-git-master-nrwl.vercel.app
nx.dev

Please sign in to comment.