feat(testing): remove test runner for react native jest

nrwl · Jul 21, 2022 · a532497 · a532497
1 parent 33fe229
commit a532497
Show file tree

Hide file tree

Showing 4 changed files with 116 additions and 22 deletions.
diff --git a/packages/react-native/migrations.json b/packages/react-native/migrations.json
@@ -47,6 +47,12 @@
       "cli": "nx",
       "description": "Rename blacklistRE to blockList in metro.config.js",
       "factory": "./src/migrations/update-14-2-1/rename-blockList-metro-config"
+    },
+    "rename-jest-preprocessor-14-4-0": {
+      "version": "14.4.0-beta.0",
+      "cli": "nx",
+      "description": "Remove transform in jest.config",
+      "factory": "./src/migrations/update-14-4-0/update-jest-config"
     }
   },
   "packageJsonUpdates": {
@@ -733,15 +739,6 @@
         }
       }
     },
-    "14.4.0": {
-      "version": "14.4.0-beta.0",
-      "packages": {
-        "jest-jasmine2": {
-          "version": "~28.1.1",
-          "alwaysAddToPackageJson": false
-        }
-      }
-    },
     "14.4.4": {
       "version": "14.4.4-beta.0",
       "packages": {

diff --git a/packages/react-native/src/migrations/update-14-4-0/update-jest-config.spec.ts b/packages/react-native/src/migrations/update-14-4-0/update-jest-config.spec.ts
@@ -0,0 +1,66 @@
+import { addProjectConfiguration, Tree } from '@nrwl/devkit';
+import { createTreeWithEmptyWorkspace } from '@nrwl/devkit/testing';
+import update from './update-jest-config';
+
+describe('Update Jest Config', () => {
+  let tree: Tree;
+
+  beforeEach(async () => {
+    tree = createTreeWithEmptyWorkspace();
+    addProjectConfiguration(tree, 'products', {
+      root: 'apps/products',
+      sourceRoot: 'apps/products/src',
+      targets: {
+        start: {
+          executor: '@nrwl/react-native:start',
+          options: {
+            port: 8081,
+          },
+        },
+        test: {
+          executor: '@nrwl/jest:jest',
+          options: {
+            jestConfig: 'apps/products/jest.config.js',
+            passWithNoTests: true,
+          },
+        },
+      },
+    });
+  });
+
+  it(`should not update if the code does not contain existing test runner`, async () => {
+    tree.write(
+      'apps/products/jest.config.js',
+      `module.exports = {
+      preset: 'react-native',
+      testRunner: 'other',
+      transform: {
+        ".xyz": "xyz-transform"
+      }
+    };`
+    );
+    await update(tree);
+
+    const jestConfig = tree.read('apps/products/jest.config.js', 'utf-8');
+    expect(jestConfig).toContain(`testRunner: 'other',`);
+  });
+
+  it(`should update if the code contains existing test runner`, async () => {
+    tree.write(
+      'apps/products/jest.config.js',
+      `module.exports = {
+  preset: 'react-native',
+  testRunner: 'jest-jasmine2',
+  transform: {
+    '\\.(js|ts|tsx)$': require.resolve('react-native/jest/preprocessor.js'),
+    '^.+\\.(bmp|gif|jpg|jpeg|mp4|png|psd|svg|webp)$': require.resolve(
+      'react-native/jest/assetFileTransformer.js',
+  }
+ };`
+    );
+    await update(tree);
+
+    const jestConfig = tree.read('apps/products/jest.config.js', 'utf-8');
+    expect(jestConfig).not.toContain(`testRunner: 'jest-jasmine2',`);
+  });
+});
diff --git a/packages/react-native/src/migrations/update-14-4-0/update-jest-config.ts b/packages/react-native/src/migrations/update-14-4-0/update-jest-config.ts
@@ -0,0 +1,42 @@
+import {
+  Tree,
+  formatFiles,
+  getProjects,
+  ProjectConfiguration,
+  logger,
+  stripIndents,
+} from '@nrwl/devkit';
+
+/**
+ * Remove the testRunner
+ */
+export default async function update(tree: Tree) {
+  const projects = getProjects(tree);
+
+  projects.forEach((project) => {
+    if (project.targets?.start?.executor !== '@nrwl/react-native:start') return;
+
+    mockSvgInJestConfig(tree, project);
+  });
+
+  await formatFiles(tree);
+}
+
+function mockSvgInJestConfig(host: Tree, project: ProjectConfiguration) {
+  const jestConfigPath = project.targets?.test?.options?.jestConfig;
+  if (!jestConfigPath || !host.exists(jestConfigPath)) return;
+  try {
+    const contents = host.read(jestConfigPath, 'utf-8');
+    if (contents.includes('@nrwl/react-native/plugins/jest/preprocessor.js'))
+      return;
+    host.write(
+      jestConfigPath,
+      contents.replace(`testRunner: 'jest-jasmine2',\n`, '')
+    );
+    formatFiles(host);
+  } catch {
+    logger.error(
+      stripIndents`Unable to update ${jestConfigPath} for project ${project.root}.`
+    );
+  }
+}
diff --git a/packages/react-native/src/utils/add-jest.ts b/packages/react-native/src/utils/add-jest.ts
@@ -1,6 +1,5 @@
-import { addDependenciesToPackageJson, Tree } from '@nrwl/devkit';
+import { Tree } from '@nrwl/devkit';
 import { jestProjectGenerator } from '@nrwl/jest';
-import { jestVersion } from '@nrwl/jest/src/utils/versions';
 
 export async function addJest(
   host: Tree,
@@ -27,7 +26,6 @@ export async function addJest(
   const content = `module.exports = {
   displayName: '${projectName}',
   preset: 'react-native',
-  testRunner: 'jest-jasmine2',
   resolver: '@nrwl/jest/plugins/resolver',
   moduleFileExtensions: ['ts', 'js', 'html', 'tsx', 'jsx'],
   setupFilesAfterEnv: ['<rootDir>/test-setup.${js ? 'js' : 'ts'}'],
@@ -43,14 +41,5 @@ export async function addJest(
 };`;
   host.write(configPath, content);
 
-  const installTask = addDependenciesToPackageJson(
-    host,
-    {},
-    { 'jest-jasmine2': jestVersion }
-  );
-
-  return () => {
-    jestTask();
-    installTask();
-  };
+  return jestTask;
 }