fix(core): ensure preinstall is only run once on repo (#18671)

nrwl · Aug 18, 2023 · adb39c4 · adb39c4 · vercel · Aug 18, 2023
1 parent 195c5bf
commit adb39c4
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/packages/devkit/src/tasks/install-packages-task.ts b/packages/devkit/src/tasks/install-packages-task.ts
@@ -42,9 +42,6 @@ export function installPackagesTask(
       cwd: join(tree.root, cwd),
       stdio: process.env.NX_GENERATE_QUIET === 'true' ? 'ignore' : 'inherit',
     };
-    if (pmc.preInstall) {
-      execSync(pmc.preInstall, execSyncOptions);
-    }
     execSync(pmc.install, execSyncOptions);
   }
 }
diff --git a/packages/workspace/src/generators/new/new.ts b/packages/workspace/src/generators/new/new.ts
@@ -1,6 +1,8 @@
 import {
   addDependenciesToPackageJson,
+  getPackageManagerCommand,
   installPackagesTask,
+  joinPathFragments,
   names,
   PackageManager,
   Tree,
@@ -11,6 +13,7 @@ import { Preset } from '../utils/presets';
 import { Linter } from '../../utils/lint';
 import { generateWorkspaceFiles } from './generate-workspace-files';
 import { addPresetDependencies, generatePreset } from './generate-preset';
+import { execSync } from 'child_process';
 
 interface Schema {
   directory: string;
@@ -48,6 +51,13 @@ export async function newGenerator(host: Tree, opts: Schema) {
   addCloudDependencies(host, options);
 
   return async () => {
+    const pmc = getPackageManagerCommand(options.packageManager);
+    if (pmc.preInstall) {
+      execSync(pmc.preInstall, {
+        cwd: joinPathFragments(host.root, options.directory),
+        stdio: process.env.NX_GENERATE_QUIET === 'true' ? 'ignore' : 'inherit',
+      });
+    }
     installPackagesTask(host, false, options.directory, options.packageManager);
     // TODO: move all of these into create-nx-workspace
     if (