Skip to content

Commit

Permalink
feat(core): sort dependencies and devDependencies (#3806)
Browse files Browse the repository at this point in the history
  • Loading branch information
puku0x committed Sep 25, 2020
1 parent 9153007 commit c3334d0
Showing 1 changed file with 15 additions and 1 deletion.
16 changes: 15 additions & 1 deletion packages/workspace/src/utils/ast-utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,17 @@ function insertAfterLastOccurrence(
return new InsertChange(file, lastItemPosition, toInsert);
}

function sortObjectByKeys(obj: unknown) {
return Object.keys(obj)
.sort()
.reduce((result, key) => {
return {
...result,
[key]: obj[key],
};
}, {});
}

export function findNodes(
node: ts.Node,
kind: ts.SyntaxKind | ts.SyntaxKind[],
Expand Down Expand Up @@ -616,7 +627,8 @@ export function addDepsToPackageJson(
...devDeps,
...(json.devDependencies || {}),
};

json.dependencies = sortObjectByKeys(json.dependencies);
json.devDependencies = sortObjectByKeys(json.devDependencies);
return json;
}),
addInstallTask({
Expand Down Expand Up @@ -644,6 +656,8 @@ export function updatePackageJsonDependencies(
...(json.devDependencies || {}),
...devDeps,
};
json.dependencies = sortObjectByKeys(json.dependencies);
json.devDependencies = sortObjectByKeys(json.devDependencies);
return json;
}),
addInstallTask({
Expand Down

0 comments on commit c3334d0

Please sign in to comment.