feat(angular): convert module-federation-dev-server to executor

nrwl · Nov 30, 2023 · c58d138 · c58d138
1 parent 1f4346f
commit c58d138
Show file tree

Hide file tree

Showing 18 changed files with 489 additions and 450 deletions.
diff --git a/docs/generated/manifests/menus.json b/docs/generated/manifests/menus.json
@@ -6536,6 +6536,14 @@
                 "isExternal": false,
                 "disableCollapsible": false
               },
+              {
+                "id": "module-federation-dev-server",
+                "path": "/nx-api/angular/executors/module-federation-dev-server",
+                "name": "module-federation-dev-server",
+                "children": [],
+                "isExternal": false,
+                "disableCollapsible": false
+              },
               {
                 "id": "webpack-browser",
                 "path": "/nx-api/angular/executors/webpack-browser",
@@ -6560,14 +6568,6 @@
                 "isExternal": false,
                 "disableCollapsible": false
               },
-              {
-                "id": "module-federation-dev-server",
-                "path": "/nx-api/angular/executors/module-federation-dev-server",
-                "name": "module-federation-dev-server",
-                "children": [],
-                "isExternal": false,
-                "disableCollapsible": false
-              },
               {
                 "id": "module-federation-dev-ssr",
                 "path": "/nx-api/angular/executors/module-federation-dev-ssr",

diff --git a/docs/generated/manifests/nx-api.json b/docs/generated/manifests/nx-api.json
@@ -67,6 +67,15 @@
         "path": "/nx-api/angular/executors/browser-esbuild",
         "type": "executor"
       },
+      "/nx-api/angular/executors/module-federation-dev-server": {
+        "description": "The module-federation-dev-server executor is reserved exclusively for use with host Module Federation applications. It allows the user to specify which remote applications should be served with the host.",
+        "file": "generated/packages/angular/executors/module-federation-dev-server.json",
+        "hidden": false,
+        "name": "module-federation-dev-server",
+        "originalFilePath": "/packages/angular/src/executors/module-federation-dev-server/schema.json",
+        "path": "/nx-api/angular/executors/module-federation-dev-server",
+        "type": "executor"
+      },
       "/nx-api/angular/executors/webpack-browser": {
         "description": "The `webpack-browser` executor is very similar to the standard `browser` builder provided by the Angular Devkit. It allows you to build your Angular application to a build artifact that can be hosted online. There are some key differences:   \n- Supports Custom Webpack Configurations  \n- Supports Incremental Building",
         "file": "generated/packages/angular/executors/webpack-browser.json",
@@ -94,15 +103,6 @@
         "path": "/nx-api/angular/executors/webpack-server",
         "type": "executor"
       },
-      "/nx-api/angular/executors/module-federation-dev-server": {
-        "description": "The module-federation-dev-server executor is reserved exclusively for use with host Module Federation applications. It allows the user to specify which remote applications should be served with the host.",
-        "file": "generated/packages/angular/executors/module-federation-dev-server.json",
-        "hidden": false,
-        "name": "module-federation-dev-server",
-        "originalFilePath": "/packages/angular/src/builders/module-federation-dev-server/schema.json",
-        "path": "/nx-api/angular/executors/module-federation-dev-server",
-        "type": "executor"
-      },
       "/nx-api/angular/executors/module-federation-dev-ssr": {
         "description": "The module-federation-dev-ssr executor is reserved exclusively for use with host Module Federation applications that use SSR. It allows the user to specify which remote applications should be served with the host.",
         "file": "generated/packages/angular/executors/module-federation-dev-ssr.json",

diff --git a/docs/generated/packages-metadata.json b/docs/generated/packages-metadata.json
@@ -62,6 +62,15 @@
         "path": "angular/executors/browser-esbuild",
         "type": "executor"
       },
+      {
+        "description": "The module-federation-dev-server executor is reserved exclusively for use with host Module Federation applications. It allows the user to specify which remote applications should be served with the host.",
+        "file": "generated/packages/angular/executors/module-federation-dev-server.json",
+        "hidden": false,
+        "name": "module-federation-dev-server",
+        "originalFilePath": "/packages/angular/src/executors/module-federation-dev-server/schema.json",
+        "path": "angular/executors/module-federation-dev-server",
+        "type": "executor"
+      },
       {
         "description": "The `webpack-browser` executor is very similar to the standard `browser` builder provided by the Angular Devkit. It allows you to build your Angular application to a build artifact that can be hosted online. There are some key differences:   \n- Supports Custom Webpack Configurations  \n- Supports Incremental Building",
         "file": "generated/packages/angular/executors/webpack-browser.json",
@@ -89,15 +98,6 @@
         "path": "angular/executors/webpack-server",
         "type": "executor"
       },
-      {
-        "description": "The module-federation-dev-server executor is reserved exclusively for use with host Module Federation applications. It allows the user to specify which remote applications should be served with the host.",
-        "file": "generated/packages/angular/executors/module-federation-dev-server.json",
-        "hidden": false,
-        "name": "module-federation-dev-server",
-        "originalFilePath": "/packages/angular/src/builders/module-federation-dev-server/schema.json",
-        "path": "angular/executors/module-federation-dev-server",
-        "type": "executor"
-      },
       {
         "description": "The module-federation-dev-ssr executor is reserved exclusively for use with host Module Federation applications that use SSR. It allows the user to specify which remote applications should be served with the host.",
         "file": "generated/packages/angular/executors/module-federation-dev-ssr.json",

diff --git a/docs/generated/packages/angular/executors/module-federation-dev-server.json b/docs/generated/packages/angular/executors/module-federation-dev-server.json
@@ -1,11 +1,10 @@
 {
   "name": "module-federation-dev-server",
-  "implementation": "/packages/angular/src/builders/module-federation-dev-server/module-federation-dev-server.impl.ts",
+  "implementation": "/packages/angular/src/executors/module-federation-dev-server/module-federation-dev-server.impl.ts",
   "schema": {
-    "version": 2,
-    "outputCapture": "direct-nodejs",
     "$schema": "http://json-schema.org/draft-07/schema",
     "title": "Schema for Module Federation Dev Server",
+    "outputCapture": "direct-nodejs",
     "description": "The module-federation-dev-server executor is reserved exclusively for use with host Module Federation applications. It allows the user to specify which remote applications should be served with the host.",
     "type": "object",
     "presets": [
@@ -148,6 +147,6 @@
   "description": "The module-federation-dev-server executor is reserved exclusively for use with host Module Federation applications. It allows the user to specify which remote applications should be served with the host.",
   "aliases": [],
   "hidden": false,
-  "path": "/packages/angular/src/builders/module-federation-dev-server/schema.json",
+  "path": "/packages/angular/src/executors/module-federation-dev-server/schema.json",
   "type": "executor"
 }
diff --git a/docs/shared/reference/sitemap.md b/docs/shared/reference/sitemap.md
@@ -323,10 +323,10 @@
       - [ng-packagr-lite](/nx-api/angular/executors/ng-packagr-lite)
       - [package](/nx-api/angular/executors/package)
       - [browser-esbuild](/nx-api/angular/executors/browser-esbuild)
+      - [module-federation-dev-server](/nx-api/angular/executors/module-federation-dev-server)
       - [webpack-browser](/nx-api/angular/executors/webpack-browser)
       - [dev-server](/nx-api/angular/executors/dev-server)
       - [webpack-server](/nx-api/angular/executors/webpack-server)
-      - [module-federation-dev-server](/nx-api/angular/executors/module-federation-dev-server)
       - [module-federation-dev-ssr](/nx-api/angular/executors/module-federation-dev-ssr)
     - [generators](/nx-api/angular/generators)
       - [add-linting](/nx-api/angular/generators/add-linting)

diff --git a/packages/angular/executors.json b/packages/angular/executors.json
@@ -19,6 +19,11 @@
       "implementation": "./src/executors/browser-esbuild/browser-esbuild.impl",
       "schema": "./src/executors/browser-esbuild/schema.json",
       "description": "Builds your application with esbuild and adds support for incremental builds."
+    },
+    "module-federation-dev-server": {
+      "implementation": "./src/executors/module-federation-dev-server/module-federation-dev-server.impl",
+      "schema": "./src/executors/module-federation-dev-server/schema.json",
+      "description": "The module-federation-dev-server executor is reserved exclusively for use with host Module Federation applications. It allows the user to specify which remote applications should be served with the host."
     }
   },
   "builders": {
@@ -37,11 +42,6 @@
       "schema": "./src/builders/webpack-server/schema.json",
       "description": "The `webpack-server` executor is very similar to the standard `server` builder provided by the Angular Devkit. It is usually used in tandem with `@nrwl/angular:webpack-browser` when your Angular application uses a custom webpack configuration and NgUniversal for SSR."
     },
-    "module-federation-dev-server": {
-      "implementation": "./src/builders/module-federation-dev-server/module-federation-dev-server.impl",
-      "schema": "./src/builders/module-federation-dev-server/schema.json",
-      "description": "The module-federation-dev-server executor is reserved exclusively for use with host Module Federation applications. It allows the user to specify which remote applications should be served with the host."
-    },
     "module-federation-dev-ssr": {
       "implementation": "./src/builders/module-federation-dev-ssr/module-federation-dev-ssr.impl",
       "schema": "./src/builders/module-federation-dev-ssr/schema.json",

diff --git a/packages/angular/executors.ts b/packages/angular/executors.ts
@@ -1,7 +1,7 @@
-export * from './src/builders/module-federation-dev-server/module-federation-dev-server.impl';
 export * from './src/builders/module-federation-dev-ssr/module-federation-dev-ssr.impl';
 export * from './src/builders/webpack-browser/webpack-browser.impl';
 export * from './src/builders/webpack-server/webpack-server.impl';
+export * from './src/executors/module-federation-dev-server/module-federation-dev-server.impl';
 export * from './src/executors/delegate-build/delegate-build.impl';
 export * from './src/executors/ng-packagr-lite/ng-packagr-lite.impl';
 export * from './src/executors/package/package.impl';