fix(core): outputs migration should handle no architect projects (#4217)

Previously, if a project didn't contain an `architect` property it would fail.
nrwl · Dec 7, 2020 · c62e556 · c62e556
1 parent 0a5ee20
commit c62e556
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/packages/workspace/migrations.json b/packages/workspace/migrations.json
@@ -152,7 +152,7 @@
       "factory": "./src/migrations/update-11-0-0/rename-workspace-schematics"
     },
     "add-outputs-in-workspace": {
-      "version": "11.0.0-beta.7",
+      "version": "11.0.0-beta.15",
       "description": "Adds `outputs` based on builders",
       "factory": "./src/migrations/update-11-0-0/add-outputs-in-workspace"
     }

diff --git a/packages/workspace/src/migrations/update-11-0-0/add-outputs-in-workspace.spec.ts b/packages/workspace/src/migrations/update-11-0-0/add-outputs-in-workspace.spec.ts
@@ -46,6 +46,9 @@ describe('add `outputs` in workspace', () => {
               },
             },
           },
+          noArchitect: {
+            projectType: 'library',
+          },
         },
       })
     );
@@ -55,7 +58,7 @@ describe('add `outputs` in workspace', () => {
       .toPromise();
 
     const config = readWorkspace(tree);
-    const { products, cart } = config.projects;
+    const { products, cart, noArchitect } = config.projects;
     expect(products.architect.build.outputs).toEqual([
       'coverage/apps/products',
     ]);
@@ -65,5 +68,9 @@ describe('add `outputs` in workspace', () => {
     expect(cart.architect.buildWithOutputsDefined.outputs).toEqual([
       'test/dir',
     ]);
+
+    expect(noArchitect).toEqual({
+      projectType: 'library',
+    });
   });
 });
diff --git a/packages/workspace/src/migrations/update-11-0-0/add-outputs-in-workspace.ts b/packages/workspace/src/migrations/update-11-0-0/add-outputs-in-workspace.ts
@@ -4,7 +4,7 @@ import { updateWorkspaceInTree } from '@nrwl/workspace';
 const addOutputs = () =>
   updateWorkspaceInTree((workspace) => {
     for (const [, project] of Object.entries<any>(workspace.projects)) {
-      for (const [, target] of Object.entries<any>(project.architect)) {
+      for (const [, target] of Object.entries<any>(project.architect || {})) {
         const builder = target?.builder;
 
         if (!builder || target.outputs) {