feat(expo): move svg to inline for starter app (#14068)

nrwl · Jan 3, 2023 · cec625e · cec625e
1 parent b19eb6c
commit cec625e
Show file tree

Hide file tree

Showing 37 changed files with 450 additions and 175 deletions.
diff --git a/packages/create-nx-workspace/bin/create-nx-workspace.ts b/packages/create-nx-workspace/bin/create-nx-workspace.ts
@@ -94,7 +94,7 @@ const presetOptions: { name: Preset; message: string }[] = [
   {
     name: Preset.ReactNative,
     message:
-      'react-native      [a workspace with a single React Native application]',
+      'react-native      [a monorepo with a single React Native application]',
   },
 ];
 

diff --git a/packages/expo/package.json b/packages/expo/package.json
@@ -33,7 +33,6 @@
     "@nrwl/react": "file:../react",
     "@nrwl/webpack": "file:../webpack",
     "@nrwl/workspace": "file:../workspace",
-    "@svgr/webpack": "^6.1.2",
     "chalk": "^4.1.0",
     "enhanced-resolve": "^5.8.3",
     "fs-extra": "^10.1.0",

diff --git a/packages/expo/plugins/with-nx-webpack.ts b/packages/expo/plugins/with-nx-webpack.ts
@@ -25,64 +25,6 @@ export async function withNxWebpack(config) {
         },
       },
     });
-    // svg rule from https://github.com/kristerkari/react-native-svg-transformer/issues/135#issuecomment-1008310514
-    rules.unshift({
-      test: /\.svg$/,
-      exclude: /node_modules/,
-      use: [
-        {
-          loader: require.resolve('@svgr/webpack'),
-          options: {
-            svgoConfig: {
-              plugins: {
-                cleanupAttrs: true,
-                cleanupEnableBackground: true,
-                cleanupIDs: true,
-                cleanupListOfValues: true,
-                cleanupNumericValues: true,
-                collapseGroups: true,
-                convertEllipseToCircle: true,
-                convertPathData: true,
-                convertShapeToPath: true,
-                convertStyleToAttrs: true,
-                convertTransform: true,
-                inlineStyles: true,
-                mergePaths: true,
-                minifyStyles: true,
-                moveElemsAttrsToGroup: true,
-                moveGroupAttrsToElems: true,
-                removeComments: true,
-                removeDesc: true,
-                removeDimensions: false,
-                removeDoctype: true,
-                removeEditorsNSData: true,
-                removeEmptyAttrs: true,
-                removeEmptyContainers: true,
-                removeEmptyText: true,
-                removeHiddenElems: true,
-                removeMetadata: true,
-                removeNonInheritableGroupAttrs: true,
-                removeRasterImages: true,
-                removeScriptElement: false,
-                removeStyleElement: false,
-                removeTitle: true,
-                removeUnknownsAndDefaults: true,
-                removeUnusedNS: true,
-                removeUselessDefs: true,
-                removeUselessStrokeAndFill: true,
-                removeViewBox: false,
-                removeXMLNS: true,
-                removeXMLProcInst: true,
-                reusePaths: true,
-                sortAttrs: true,
-                sortDefsChildren: true,
-                convertColors: false,
-              },
-            },
-          },
-        },
-      ],
-    });
   }
 
   const extensions = ['.ts', '.tsx', '.mjs', '.js', '.jsx'];

diff --git a/packages/expo/src/generators/application/files/assets/logo.png b/packages/expo/src/generators/application/files/assets/logo.png
diff --git a/packages/expo/src/generators/application/files/assets/star.svg b/packages/expo/src/generators/application/files/assets/star.svg