fix(webpack): ensure NODE_ENV is defaulted to development for dev-ser…

…ver, and HMR works
nrwl · Feb 10, 2023 · dcd4d50 · dcd4d50
1 parent 47a4ff4
commit dcd4d50
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/packages/webpack/src/executors/dev-server/dev-server.impl.ts b/packages/webpack/src/executors/dev-server/dev-server.impl.ts
@@ -24,6 +24,9 @@ export async function* devServerExecutor(
   serveOptions: WebDevServerOptions,
   context: ExecutorContext
 ) {
+  // Default to dev mode so builds are faster and HMR mode works better.
+  process.env.NODE_ENV ??= 'development';
+
   const { root: projectRoot, sourceRoot } =
     context.projectsConfigurations.projects[context.projectName];
   const buildOptions = normalizeOptions(

diff --git a/packages/webpack/src/plugins/write-index-html-plugin.ts b/packages/webpack/src/plugins/write-index-html-plugin.ts
@@ -360,8 +360,17 @@ export class WriteIndexHtmlPlugin {
       name: string;
       extension: string;
     }[] = [];
+
+    // This test excludes files generated by HMR (e.g. main.hot-update.js).
+    const jsAssetRegExp = /(?<!hot-update).js$/;
+
     for (const { file, name, extension, initial } of files) {
-      if (name && initial && extensionFilter.includes(extension)) {
+      if (
+        name &&
+        initial &&
+        extensionFilter.includes(extension) &&
+        jsAssetRegExp.test(file)
+      ) {
         filteredFiles.push({ file, extension, name });
       }
     }