fix(webpack): ensure NODE_ENV is defaulted to development for dev-ser…

…ver, and HMR works
nrwl · Feb 10, 2023 · dd85383 · dd85383
1 parent 47a4ff4
commit dd85383
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/packages/webpack/src/executors/dev-server/dev-server.impl.ts b/packages/webpack/src/executors/dev-server/dev-server.impl.ts
@@ -24,6 +24,9 @@ export async function* devServerExecutor(
   serveOptions: WebDevServerOptions,
   context: ExecutorContext
 ) {
+  // Default to dev mode so builds are faster and HMR mode works better.
+  process.env.NODE_ENV ??= 'development';
+
   const { root: projectRoot, sourceRoot } =
     context.projectsConfigurations.projects[context.projectName];
   const buildOptions = normalizeOptions(

diff --git a/packages/webpack/src/plugins/write-index-html-plugin.ts b/packages/webpack/src/plugins/write-index-html-plugin.ts
@@ -360,6 +360,7 @@ export class WriteIndexHtmlPlugin {
       name: string;
       extension: string;
     }[] = [];
+
     for (const { file, name, extension, initial } of files) {
       if (name && initial && extensionFilter.includes(extension)) {
         filteredFiles.push({ file, extension, name });