fix(react): aliases should be an array in schematics #10198
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aliases is an array in the type definitions, but a string in the react JSON, which seems like a mistake.
It'd be really nice if you have a JSON schema for these JSON files and hook them up to it, so you would catch these problems much earlier on (even if just through editor support, i.e. the dev seeing their editor tell them its wrong while changing it).
You could also setup a test which uses ajv to validate each of these files against the schema in CI. that might be nice.
happy to implement either of those solutions if i know where in the repo they'd belong
Related Issue(s)
Fixes #10193