Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Workspace Run Commands no longer accepting optional properties #10844

Closed
tanepiper opened this issue Jun 22, 2022 · 2 comments
Closed

Comments

@tanepiper
Copy link

Current Behavior

When running nx:run-commands executor - optional properties are being ignored

Expected Behavior

When running nx:run-commands executor - optional properties should be added as arguments to the call

This appears to be a recent regression:

- @nrwl/workspace 14.3.6
+ @nrwl/workspace 14.1.9

The following config is no longer working with the lastest version, but works if I go to main which has the older version:

"build": {
      "executor": "nx:run-commands",
      "defaultConfiguration": "local",
      "options": {
        "cwd": "apps/ikg-hub",
        "commands": ["astro build"],
        "parallel": false,
        "outputPath": "../../../dist/apps/ikg-hub"
      },
      "configurations": {
        "local": {
          "config": "astro.local.mjs"
        },
        "dev": {
          "config": "astro.dev.mjs"
        },
        "stage": {
          "config": "astro.stage.mjs"
        },
        "production": {
          "config": "astro.prod.mjs"
        }
      }
    },

Steps to Reproduce

Upgrade to @nrwl/workspace 14.3.x

Environment

Node : 18.3.0
   OS   : darwin x64
   pnpm : 7.1.9
   
   nx : 14.3.6
   @nrwl/angular : Not Found
   @nrwl/cypress : 14.3.6
   @nrwl/detox : Not Found
   @nrwl/devkit : 14.3.6
   @nrwl/eslint-plugin-nx : 14.3.6
   @nrwl/express : Not Found
   @nrwl/jest : 14.3.6
   @nrwl/js : 14.3.6
   @nrwl/linter : 14.3.6
   @nrwl/nest : Not Found
   @nrwl/next : Not Found
   @nrwl/node : Not Found
   @nrwl/nx-cloud : Not Found
   @nrwl/nx-plugin : Not Found
   @nrwl/react : 14.3.6
   @nrwl/react-native : Not Found
   @nrwl/schematics : Not Found
   @nrwl/storybook : 14.3.6
   @nrwl/web : 14.3.6
   @nrwl/workspace : 14.3.6
   typescript : 4.7.4
   ---------------------------------------
   Community plugins:
         @jscutlery/semver: 2.25.2
@github-actions
Copy link

This issue has been automatically marked as stale because it hasn't had any recent activity. It will be closed in 14 days if no further activity occurs.
If we missed this issue please reply to keep it active.
Thanks for being a part of the Nx community! 🙏

@github-actions
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants