Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(angular): add entity name to entity model for ngrx classes #10845 #10853

Merged
merged 1 commit into from
Jun 23, 2022

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Jun 22, 2022

Current Behavior

We do not prepend the entity name to the entity model when generating NgRx class syntax.

We do this for creator syntax

Expected Behavior

We should prepend the entity name to the entity model when generating NgRx class syntax.

Related Issue(s)

Fixes #10845

@Coly010 Coly010 self-assigned this Jun 22, 2022
@vercel
Copy link

vercel bot commented Jun 22, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Jun 22, 2022 at 6:35PM (UTC)

@Coly010 Coly010 force-pushed the 10845-classname-ngrx-classes branch from c7ce64b to e225365 Compare June 22, 2022 18:35
Copy link
Member

@leosvelperez leosvelperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@Coly010 Coly010 merged commit 251af50 into nrwl:master Jun 23, 2022
@Coly010 Coly010 deleted the 10845-classname-ngrx-classes branch June 23, 2022 08:40
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Entity interface should be named 'what it is' for any given store
2 participants