Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ascii as dependency to the blog isn't reflected in nx graph #10898

Closed
2 tasks
mikemykhaylov opened this issue Jun 25, 2022 · 8 comments
Closed
2 tasks
Labels

Comments

@mikemykhaylov
Copy link

mikemykhaylov commented Jun 25, 2022

Documentation issue

  • Reporting a documentation bug
  • Documentation improvement

Is there a specific documentation page you are reporting?

https://nx.dev/core-tutorial/03-share-assets

Additional context or description

After following the first 3 steps of the tutorial, when I run nx graph, it fails to detect the dependence of blog on ascii, despite the documentation saying otherwise.

/packages/blog/package.json

{
  "name": "blog",
  "description": "eleventy blog",
  "version": "1.0.0",
  "dependency": {
    "ascii": "*"
  },
  "scripts": {
    "build": "eleventy --input=./src --output=../../dist/packages/blog",
    "serve": "eleventy --serve --input=./src --output=../../dist/packages/blog"
  }
}

/packages/ascii/project.json

{
  "root": "packages/ascii",
  "sourceRoot": "packages/ascii/assets",
  "projectType": "library"
}

Running nx graph yields

Screen Shot 2022-06-24 at 22 13 20

@AgentEnder AgentEnder added the scope: core core nx functionality label Jun 27, 2022
@kyujonglee
Copy link

me too.

@johnstew
Copy link

johnstew commented Sep 7, 2022

Same

@KlausEverWalkingDev
Copy link

Running nx graph yields

Screen Shot 2022-06-24 at 22 13 20

For me neither the implicit arrow appears.

@prajendra-is
Copy link

This also happened to me, and I'm also unable to see the ascii cow in the browser after running npx nx serve blog. Are you able to see the cow in the brower?
Screen Shot 2022-09-13 at 4 17 53 PM

@gmotyl
Copy link

gmotyl commented Sep 16, 2022

same

@gmotyl
Copy link

gmotyl commented Sep 16, 2022

I was able to see the cow after fixing ascii.md

pageTitle: Some ASCII Art
---

Welcome to [The Restaurant at the End of the Universe](https://hitchhikers.fandom.com/wiki/Ameglian_Major_Cow)

<pre>
{% renderFile "../ascii/assets/cow.txt" %}
</pre>

Art courtesy of [cowsay](https://www.npmjs.com/package/cowsay).

image

but dependency graph still looks like this:

image

@isaacplmann
Copy link
Collaborator

This tutorial is no longer referenced from the getting started page

@github-actions
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

8 participants