Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react): improve babel preset options #10940

Merged
merged 1 commit into from
Sep 22, 2022

Conversation

jasongerbes
Copy link
Contributor

@jasongerbes jasongerbes commented Jun 28, 2022

Improved the @nrwl/react/babel preset to allow for customisation of all options provided by
the @nrwl/web/babel preset.

Current Behavior

Only the useBuiltIns option of the @nrwl/web/babel preset can be configured when using the @nrwl/react/babel preset:

{
    "presets": [
        [
            "@nrwl/react/babel",
            {
                "runtime": "automatic",
                "importSource": "react",
                "useBuiltIns": "usage"
            }
        ]
    ],
    "plugins": []
}

Expected Behavior

All options provided by the @nrwl/web/babel preset should be configurable when using the @nrwl/react/babel preset:

{
    "presets": [
        [
            "@nrwl/react/babel",
            {
                "runtime": "automatic",
                "importSource": "react",
                "useBuiltIns": "usage",
                "decorators": {
                    "decoratorsBeforeExport": true,
                    "legacy": false
                },
                "classProperties": {
                    "loose": false
                }
            }
        ]
    ],
    "plugins": []
}

Related Issue(s)

Fixes #10939

Improved the '@nrwl/react/babel' preset to allow for customisation of all options provided by
the
'@nrwl/web/babel' preset.

ISSUES CLOSED: nrwl#10939
@nx-cloud
Copy link

nx-cloud bot commented Jun 28, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 644a9e3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 12 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Jun 28, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Jun 28, 2022 at 11:45PM (UTC)

@jaysoo jaysoo merged commit 4dc331c into nrwl:master Sep 22, 2022
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve options for the React babel preset
3 participants