-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): use globbing also for workspace file patterns without '*' #11298
Conversation
Input strings for root filesets can be defined as patterns even if they don't contain `'*'` in it. Few examples: ``` inputs: ["{workspaceRoot}/.babelrc?(.json)", "{workspaceRoot}/tsconfig.{e2e-base,ts-node}.json" ``` Making perf optimizations by skipping minimatch for a few static files is not worth the tradeoff.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Alternatively, condition checking for presence of minimatch pattern ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution!
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This change allows cache input strings for
{workspaceRoot}
filesets to be parsed as glob patterns even if they don't contain asterisk*
inside.Few examples:
Making perf optimizations by skipping minimatch for a few static files might not be worth the tradeoff. (related commit: 15ccae0)
Note: this is a behaviour related to "cache inputs" feature introduced in Nx 14.4.
Current Behavior
Rerunning a target with above defined inputs with one of
.babelrc
ortsconfig.{e2e-base,ts-node}.json
files updated will not invalidate a cache for the target.Expected Behavior
Those files would get matched by
Hasher
and the Nx cache for the target would get invalidated.