fix(angular): add check before attempting to collect secondary entrypoints #11437 #11496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Coly010
force-pushed
the
11437-ng-mf-infinite-loop
branch
3 times, most recently
from
09a3f2c
to
ee97efd
Compare
Comment on lines
73
to
85
| const tsConfigAliasesForLibWithSecondaryEntryPoints = Object.entries( | ||
| tsconfigPathAliases | ||
| ).reduce((acc, [tsKey, tsPaths]) => { | ||
| if (!tsKey.startsWith(library.importKey)) { | ||
| return { ...acc }; | ||
| } | ||
|
|
||
| if (tsPaths.some((path) => path.startsWith(`${library.root}/`))) { | ||
| acc = { ...acc, [tsKey]: tsPaths }; | ||
| } | ||
|
|
||
| return acc; | ||
| }, {}); |
There was a problem hiding this comment.
There's already some sort of filtering inside collectWorkspaceLibrarySecondaryEntryPoints which becomes useless with this change. I think it would be better to move this filter inside that function and replace the old filter that's there. Wdyt?
There was a problem hiding this comment.
Yeah I think that makes sense, I updated it
Coly010
force-pushed
the
11437-ng-mf-infinite-loop
branch
from
ee97efd
to
6b93fc8
Compare
Coly010
force-pushed
the
11437-ng-mf-infinite-loop
branch
from
6b93fc8
to
c486293
Compare
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
A lib that has the same starting name as another library forces an infinite loop when checking for secondary entry points
Expected Behavior
We're checking all libraries for secondary entry points, when we should only check those that might contain it.
This should also have a minor performance gain
Related Issue(s)
Fixes #11437