Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Jest version 29.x.x #11892

Closed
anschm opened this issue Sep 6, 2022 · 17 comments · Fixed by #14701
Closed

Support Jest version 29.x.x #11892

anschm opened this issue Sep 6, 2022 · 17 comments · Fixed by #14701
Assignees
Labels
outdated scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx type: feature

Comments

@anschm
Copy link

anschm commented Sep 6, 2022

Migrate NX workspace to support Jest version 29.

@barbados-clemens barbados-clemens self-assigned this Sep 9, 2022
@barbados-clemens barbados-clemens added the scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx label Sep 9, 2022
@barbados-clemens
Copy link
Contributor

currently in progress.
ts-jest just released the v29 support (with breaking changes)
and still waiting on jest-preset-angular and @types/jest to make releases.

@bulldog98
Copy link
Contributor

@types/jest has a 29 version now

@barbados-clemens
Copy link
Contributor

and looks like jest-preset-angular just merged their support.
I'm mostly though with the migration to handle breaking changes and getting a PR up for jest 29 is my priority this week. I'll comment when the PR is up.

@minijus
Copy link
Contributor

minijus commented Oct 13, 2022

With Angular 15 dropping support for Node.js 16.10 this task to support Jest 29 could suddenly become very important. See: angular/angular-cli#24026

There is known issue with memory consumption on Jest 28 and Node.js 16.10+: jestjs/jest#11956
Jest 29 introduces a workaround for it - an option workerIdleMemoryLimit.

Basically Angular 15 removes an option to use Node.js version which is not affected by memory consumption issue, but while nx does not support Jest 29 all nx repos are stuck in limbo.

@barbados-clemens is there any work in progress PR for Jest 29 support? Maybe there would be extra contributors willing to help.

Ideally Angular 15 support on nx (#12112) should be released together with Jest 29 support.

@barbados-clemens
Copy link
Contributor

barbados-clemens commented Oct 13, 2022

Waiting on jest-preset-angular to release with support.

@muuvmuuv
Copy link
Contributor

Seems to be merged thymikee/jest-preset-angular#1840
but release is still in progress while this one here is open and not tested against main thymikee/jest-preset-angular#1774 (comment)

@anschm
Copy link
Author

anschm commented Nov 30, 2022

The release 12.2.3 is now avalaible and supports Jest 29

@nzacca
Copy link

nzacca commented Nov 30, 2022

12.2.3 does not support Jest 29. 12.2.3 only supports Angular 15. master has the jest 29 updates but Angular 15 support was cherry picked to form 12.2.3. Still waiting on the ts-jest updates as per thymikee/jest-preset-angular#1774 (comment) .

@bendehghan
Copy link

Hey guys,
We're still blocked on jest 29 for our angular project. Seems there is a dependency here for it or this is depending on jest-preset-angular. Can we please try to resolve this? Angular 15 has been out for a while now. Can someone please update on what is currently missing and what help is needed to get this resolved?
Thank you, Ben

@barbados-clemens
Copy link
Contributor

as per the comment above, jest-preset-angular does not support jest 29. only angular 15 so nothing should be blocking your update to angular 15.

12.2.3 does not support Jest 29. 12.2.3 only supports Angular 15. master has the jest 29 updates but Angular 15 support was cherry picked to form 12.2.3. Still waiting on the ts-jest updates as per thymikee/jest-preset-angular#1774 (comment) .

@alfaproject
Copy link
Contributor

For extra context for the people puzzled with Angular 15 being blocked for some folks: we are blocked updating to Angular 15 because we can't use Jest 29 workaround for the node 16.10+ memory leak. Angular 15 now requires a higher version of node.

@beeman
Copy link
Contributor

beeman commented Jan 5, 2023

Please Nrwl consider taking over maintenance of that depency. It's a pretty sad state of things that the whole nx ecosystem has to hold back upgrading one dependency.

@barbados-clemens
Copy link
Contributor

there are no plans to take over maintenance of jest-preset-angular.
@Tommy228 has started work on the last changes needed by jest-preset-angular with this PR
thymikee/jest-preset-angular#1901

Those interested in should follow that issue and help contribute to that PR in a meaningful and helpful way to make get support merged.

@beeman
Copy link
Contributor

beeman commented Jan 11, 2023

there are no plans to take over maintenance of jest-preset-angular. @Tommy228 has started work on the last changes needed by jest-preset-angular with this PR thymikee/jest-preset-angular#1901

Those interested in should follow that issue and help contribute to that PR in a meaningful and helpful way to make get support merged.

Thanks for responding Caleb. Hope this will address the issue soon.

@jbarmash
Copy link

jbarmash commented Jan 27, 2023

jest-preset-angular just resolved Jest 29 upgrade. Available in v13.0.0-next.1 release.

https://github.com/thymikee/jest-preset-angular/releases/tag/v13.0.0-next.1

The PR:
thymikee/jest-preset-angular#1937

@eweap
Copy link
Contributor

eweap commented Feb 20, 2023

jest-preset-angular v13.0.0 has been released with jest 29 support !

The CHANGELOG:
https://github.com/thymikee/jest-preset-angular/blob/main/CHANGELOG.md

@github-actions
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx type: feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.