-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(linter): check for all .eslintrc.* files when generating a package #12515
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Thank you for adding support for these files! We also have a migration which will add these global files as an input into the Could you take a look at adding support for these files there as well? |
…s and added tests
Hey @FrozenPandaz I've added the new eslint files to the migrations now. I hope it's correct, I noticed the snapshot before showed "!{projectRoot}/.eslintrc.json" |
], | ||
"production": Array [ | ||
"default", | ||
"!{projectRoot}/.eslintrc.json", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FrozenPandaz This is the snapshot in question.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably a typo. Interestingly how that worked.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one minor comment.
Everything else looks good to me! Thank you
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
.eslintrc.json
file is still generated if we are using other eslint config file formats, for example.eslintrc
.Expected Behavior
.eslintrc.*
file that matches any of the possible.eslintrc.*
formats listed here, in the root of the monorepo. We should not generate a new.eslintrc.json
file.Related Issue(s)
Enhances #10080