Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve doc and provide repo #12958

Closed
2 tasks
mohsenbb opened this issue Nov 3, 2022 · 2 comments · Fixed by #13900
Closed
2 tasks

improve doc and provide repo #12958

mohsenbb opened this issue Nov 3, 2022 · 2 comments · Fixed by #13900
Assignees
@Coly010
Labels
outdated scope: angular Issues related to Angular support in Nx type: docs

Comments

@mohsenbb
Copy link

mohsenbb commented Nov 3, 2022

Documentation issue

  • Reporting a typo
  • [ x] Reporting a documentation bug
  • [ x] Documentation improvement
  • Documentation feedback

Is there a specific documentation page you are reporting?

https://nx.dev/recipes/module-federation/dynamic-module-federation-with-angular

Additional context or description

  1. New generation adds folders under packages/, but doc keeps saying app/
  2. No instruction to run the last step! I guessed and got a page with routes, but no link works! I ran nx serve employee --devRemotes=login,todo, but no navigation.
  3. Why, why not give the repo where the code is stored to refer/compare back to?
@FrozenPandaz FrozenPandaz added the scope: angular Issues related to Angular support in Nx label Nov 3, 2022
@Coly010
Copy link
Contributor

Coly010 commented Nov 7, 2022

I'll push the fix to the docs now, then I'll follow up with a repo

Coly010 added a commit to Coly010/nx that referenced this issue Nov 7, 2022
@Coly010
docs(angular): fixup the preset to allow apps directory nrwl#12958
1f2a78a
Coly010 added a commit that referenced this issue Nov 7, 2022
@Coly010
docs(angular): fixup the preset to allow apps directory #12958 (#13025)
b188814
Coly010 added a commit to Coly010/nx that referenced this issue Dec 19, 2022
@Coly010
docs(angular): add example repo for dynamic federation nrwl#12958
5c770f8
@Coly010 Coly010 mentioned this issue Dec 19, 2022
Merged
Coly010 added a commit to Coly010/nx that referenced this issue Dec 19, 2022
@Coly010
docs(angular): add example repo for dynamic federation nrwl#12958
b1935f0
Coly010 added a commit to Coly010/nx that referenced this issue Dec 19, 2022
@Coly010
docs(angular): add example repo for dynamic federation nrwl#12958
b6e5ff2
Coly010 added a commit to Coly010/nx that referenced this issue Dec 19, 2022
@Coly010
docs(angular): add example repo for dynamic federation nrwl#12958
1a552b4
Coly010 added a commit that referenced this issue Dec 19, 2022
@Coly010
docs(angular): add example repo for dynamic federation #12958 (#13900)
079753d
@github-actions
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Coly010 Coly010

Labels
outdated scope: angular Issues related to Angular support in Nx type: docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(angular): add example repo for dynamic federation #12958 Coly010/nx
3 participants
@FrozenPandaz @Coly010 @mohsenbb