Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@nrwl/expo does not support workspaceLayout.appsDir on generate:application #12992

Closed
danielprrazevedo opened this issue Nov 4, 2022 · 3 comments · Fixed by #13160
Closed
Assignees
Labels
outdated scope: react-native Issues relating to React Native type: bug

Comments

@danielprrazevedo
Copy link

Current Behavior

If I have the workspaceLayout.appsDir option set in nx.json to projects, it creates the app in the apps directory

Expected Behavior

The expo app should be created in the projects directory
It's not a new behavior, I noticed that there is no change in the commit history for that package

Steps to Reproduce

npx create-nx-workspace
✔ Choose your style                     · integrated
✔ What to create in the new workspace   · apps
✔ Repository name                       · nx-expo-example
✔ Enable distributed caching to make your CI faster · Yes

Repo Example

Environment

 >  NX   Report complete - copy this into the issue template

   Node : 16.15.1
   OS   : darwin x64
   npm  : 8.15.0
   
   nx : 15.0.8
   @nrwl/angular : Not Found
   @nrwl/cypress : 15.0.8
   @nrwl/detox : 15.0.8
   @nrwl/devkit : 15.0.8
   @nrwl/esbuild : Not Found
   @nrwl/eslint-plugin-nx : 15.0.8
   @nrwl/expo : 15.0.8
   @nrwl/express : Not Found
   @nrwl/jest : 15.0.8
   @nrwl/js : 15.0.8
   @nrwl/linter : 15.0.8
   @nrwl/nest : Not Found
   @nrwl/next : Not Found
   @nrwl/node : Not Found
   @nrwl/nx-cloud : 15.0.2
   @nrwl/nx-plugin : Not Found
   @nrwl/react : 15.0.8
   @nrwl/react-native : Not Found
   @nrwl/rollup : 15.0.8
   @nrwl/schematics : Not Found
   @nrwl/storybook : 15.0.8
   @nrwl/web : 15.0.8
   @nrwl/webpack : 15.0.8
   @nrwl/workspace : 15.0.8
   typescript : 4.8.4
   ---------------------------------------
   Local workspace plugins:
   ---------------------------------------
   Community plugins:
@AgentEnder AgentEnder added the scope: react-native Issues relating to React Native label Nov 4, 2022
@danielprrazevedo
Copy link
Author

An additional information, after studying a bit of the package's code, I noticed that the problem may affect other areas of the project.
For some things it looks for the root node_modules doing the navigation between folders, so if the subdirectory is in a different two level tree this may require creating a more specific navigation.
So maybe it doesn't just affect the app build directory but also the generation of some expo config files

@danielprrazevedo
Copy link
Author

Awesome Thanks! 🚀🚀

@github-actions
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated scope: react-native Issues relating to React Native type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants