Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react): add minimal flag #13446

Merged
merged 1 commit into from
Nov 28, 2022
Merged

feat(react): add minimal flag #13446

merged 1 commit into from
Nov 28, 2022

Conversation

xiongemi
Copy link
Collaborator

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@xiongemi xiongemi requested a review from jaysoo November 28, 2022 15:15
@vercel
Copy link

vercel bot commented Nov 28, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview Nov 28, 2022 at 3:59PM (UTC)

@jaysoo
Copy link
Member

jaysoo commented Nov 28, 2022

Small typo, otherwise LGTM

@@ -187,6 +187,11 @@
"enum": ["vite", "webpack"],
"x-prompt": "Which bundler do you want to use to build the application?",
"default": "webpack"
},
"minimal": {
"description": "Generate a React app with a minial setup. Have inline test support, not separate tests files.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: minial -> minimal

@xiongemi xiongemi force-pushed the feature/add-minimal-flag-react branch from 3d1ee7b to 4f78ea7 Compare November 28, 2022 15:51
@xiongemi xiongemi requested a review from jaysoo November 28, 2022 16:39
@jaysoo jaysoo merged commit 662f541 into master Nov 28, 2022
@xiongemi xiongemi deleted the feature/add-minimal-flag-react branch January 16, 2023 19:38
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants