feat(core): use node_modules/.cache/nx as default for projectGraphCac… #13470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…heDirectory The default value for projectGraphCacheDirectory is changed to `node_modules/.cache/nx`. The rationale for this is that if someone moves the nx cache of artefacts by setting `NX_CACHE_DIRECTORY` or setting `cacheDirectory` in `nx.json` to some location that will be shared among multiple worktrees/repos then it is undesirable to have daemon and project graph cache shared too. This is a BREAKING change as projectGraphCacheDirectory would previously move with the achanges to `cacheDirectory` and/or `NX_CACHE_DIRECTORY`. It is however not a breaking change that is expected to affect anyone negatively and in the unlikely case we have environment NX_PROJECTNX_PROJECT_GRAPH_CACHE_DIRECTORY BREAKING CHANGE: The default of projectGraphCacheDirectory no longer follows the location of cacheDirectory
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was referenced Nov 29, 2022
|
Thank you for your contribution! This looks great. 🎉 |
FrozenPandaz
approved these changes
Nov 29, 2022
jonhamm
deleted the
default-projectGraphCacheDirectory-to-workspace-local-cache
branch
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When changing the location of the nx cache directory away from default
node_modules/.cache/nx.cacheDirectoryoption innx.jsonorNX_CACHE_DIRECTORYenvironment variable -the location of
projectGraphCacheDirectoryfollows the nx cache directoryunless environment
NX_PROJECT_GRAPH_CACHE_DIRECTORYis set.Expected Behavior
The location of
projectGraphCacheDirectoryshould stay innode_modules/.cache/nxunless environment
NX_PROJECT_GRAPH_CACHE_DIRECTORYis set.The rationale is that changing the normal cache directory to some directory shared by
multiple worktrees/repos will result in error if the
projectGraphCacheDirectoryis also shared.BREAKING CHANGE:
The default of projectGraphCacheDirectory no longer follows the location of cacheDirectory
Related Issue(s)
This is one of two Pull Requests fixing the same problem
This one does the minimal changes
Only one of the PRs should be merged
Closes #13471
Fixes #