feat(js): added a minimal option to the library generator

[Phillip9587]

Current Behavior

When generating libraries i have no option to skip the generation of the README.md file. I have to delete the file by hand if I don't want it.

When generating buildable libraries a entry is added to the assets array of the build target. I have to delete that manually to if I want a clean project.json/workspace.json without unnecessary entries.

These often unnecessary generated READMEs add extra vertical space to a opened lib.

Expected Behavior

I set the includeReadme flag to false when generating libs and end up with a lib without a README.md and without a assets property in the build targets options when generating a buildable lib.

includeReadme defaults to true so nothing has changed when not specifing this option.

I just implemented it for the @nrwl/js:library generator but I am willing to submit follow-up PRs if this gets merged.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
nx-dev	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Mar 3, 2023 at 6:52PM (UTC)

[Phillip9587]

The following test are not changed. The desribe('--buildable', () => { block was nested into the describe('--unit-test-runner jest', () => { which was wrong I think. I removed the nesting.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit fae909b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 8 targets

• nx run-many -t e2e-macos --parallel=1 --exclude=e2e-detox
• nx affected --target=e2e --base=c9564351336df4e31a2babcce70e59e981dbab57 --head=fae909b9312d2ebbc57d145b6bf2bb46aa75b67f --exclude=e2e-storybook,e2e-storybook-angular --parallel=1
• nx affected --target=test --base=c9564351336df4e31a2babcce70e59e981dbab57 --head=fae909b9312d2ebbc57d145b6bf2bb46aa75b67f --parallel=1
• nx affected --target=build --base=c9564351336df4e31a2babcce70e59e981dbab57 --head=fae909b9312d2ebbc57d145b6bf2bb46aa75b67f --parallel=3
• nx run-many -t root-lint check-imports check-commit check-lock-files depcheck --parallel=1 --no-dte
• nx affected --target=lint --base=c9564351336df4e31a2babcce70e59e981dbab57 --head=fae909b9312d2ebbc57d145b6bf2bb46aa75b67f --parallel=3
• nx-cloud record -- nx format:check --base=c9564351336df4e31a2babcce70e59e981dbab57 --head=fae909b9312d2ebbc57d145b6bf2bb46aa75b67f
• nx documentation --no-dte

---

Sent with 💌 from NxCloud.

[jaysoo]

Hi @Phillip9587 can we rename the option to --minimal? We started adopting a minimal setup option for many of our generators to skip boilerplate.

Happy to review again once updated, or we can add this flag in another PR.

[Phillip9587]

@jaysoo Updated it. Can you review it please?

[Phillip9587]

CI Failure is not related to this PR i think.

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.