Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite): remove default for hmr from schema.json #13654

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

mandarini
Copy link
Member

@mandarini mandarini commented Dec 6, 2022

The reason for this change is the following:

If there's a default set in schema.json, then the default can ONLY be overwritten in project.json or if the user passes the option through a flag (eg: nx serve my-app --hmr=false). It cannot be overwritten in vite.config.ts. I think it's best to allow the user to be able to set all options in vite.config.ts if they want to. So it's best to not impose any defaults.

In this PR, I am adding the hmr: true in project.json, so a user can either change it there, or remove it completely, and set it in vite.config.ts.

@mandarini mandarini requested a review from jaysoo December 6, 2022 12:24
@vercel
Copy link

vercel bot commented Dec 6, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview Dec 6, 2022 at 0:38AM (UTC)

@mandarini mandarini self-assigned this Dec 6, 2022
@jaysoo jaysoo merged commit 7d329c0 into nrwl:master Dec 6, 2022
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants