-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(testing): jest batch mode improvements #13744
Merged
barbados-clemens
merged 6 commits into
nrwl:master
from
barbados-clemens:fix/jest-batch-mode-project-failure
Jan 27, 2023
Merged
fix(testing): jest batch mode improvements #13744
barbados-clemens
merged 6 commits into
nrwl:master
from
barbados-clemens:fix/jest-batch-mode-project-failure
Jan 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barbados-clemens
added
the
scope: testing tools
Issues related to Cypress / Jest / Playwright / Vitest support in Nx
label
Dec 9, 2022
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
barbados-clemens
force-pushed
the
fix/jest-batch-mode-project-failure
branch
from
January 25, 2023 20:09
175c290
to
98e0489
Compare
barbados-clemens
force-pushed
the
fix/jest-batch-mode-project-failure
branch
from
January 26, 2023 22:24
98e0489
to
387c97a
Compare
barbados-clemens
changed the title
fix(testing): prevent process hanging when using jest batch mode
fix(testing): jest batch mode improvements
Jan 27, 2023
barbados-clemens
force-pushed
the
fix/jest-batch-mode-project-failure
branch
from
January 27, 2023 16:32
387c97a
to
8f3c486
Compare
AgentEnder
requested changes
Jan 27, 2023
packages/nx/src/tasks-runner/life-cycles/store-run-information-life-cycle.spec.ts
Show resolved
Hide resolved
packages/nx/src/tasks-runner/life-cycles/store-run-information-life-cycle.ts
Outdated
Show resolved
Hide resolved
packages/nx/src/tasks-runner/life-cycles/store-run-information-life-cycle.ts
Outdated
Show resolved
Hide resolved
packages/nx/src/tasks-runner/life-cycles/task-profiling-life-cycle.ts
Outdated
Show resolved
Hide resolved
AgentEnder
approved these changes
Jan 27, 2023
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
sometimes when running with jest batch mode process will hang even after running all the tests
(an issue where the process would exit before the complete message could be sent to the parent )
Expected Behavior
process doesn't hang
correct time calcuations
Related Issue(s)
Fixes #