feat(react): add nx.server.ready message from Node process to any potential parent process #13808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Coly010
approved these changes
Dec 13, 2022
packages/react/src/generators/remote/files/module-federation-ssr/server.ts__tmpl__
Outdated
Show resolved
Hide resolved
jaysoo
force-pushed
the
feat/react-module-federation-ssr
branch
2 times, most recently
from
4cd17a2
to
fc86b53
Compare
jaysoo
force-pushed
the
feat/react-module-federation-ssr
branch
from
fc86b53
to
d59377a
Compare
jaysoo
force-pushed
the
feat/react-module-federation-ssr
branch
from
d59377a
to
e758085
Compare
jaysoo
force-pushed
the
feat/react-module-federation-ssr
branch
from
e758085
to
ea323fe
Compare
jaysoo
force-pushed
the
feat/react-module-federation-ssr
branch
from
ea323fe
to
5c040fb
Compare
…ential parent process
jaysoo
force-pushed
the
feat/react-module-federation-ssr
branch
from
5c040fb
to
4bc75f5
Compare
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it possible for the host app to start remotes in a separate process, and listen for the
nx.server.readymessage from child process.This is needed for SSR and Module Federation to work properly.
Changes
server.tsfiles so it's easier to add MF-related logic.run-commandsto serve static server rather than@nrwl/js:nodeexecutor.