Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(angular): skip invalid projects or targets instead of erroring when migrating from angular cli to nx monorepo #13871

Conversation

leosvelperez
Copy link
Member

Current Behavior

When migrating an Angular CLI workspace to an Nx workspace with a monorepo layout, the whole migration is stopped if any project has an issue.

Expected Behavior

When migrating an Angular CLI workspace to an Nx workspace with a monorepo layout, the migration is not stopped if projects or targets have issues. If a specific project has a blocking issue, the project migration is skipped. Likewise, if a specific target has a blocking issue, the target migration is skipped. In both cases, the rest of the migration continues.

Related Issue(s)

Fixes #

…hen migrating from angular cli to nx monorepo
@leosvelperez leosvelperez self-assigned this Dec 16, 2022
@vercel
Copy link

vercel bot commented Dec 16, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Dec 16, 2022 at 1:53PM (UTC)

@leosvelperez leosvelperez marked this pull request as ready for review December 16, 2022 14:24
Copy link
Contributor

@Coly010 Coly010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@leosvelperez leosvelperez merged commit 1247e04 into nrwl:master Dec 16, 2022
@leosvelperez leosvelperez deleted the angular/loose-ng-cli-migration-restrictions branch December 16, 2022 15:26
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants