fix(core): combine serial and parallel execution + forward sigint to child process

[caioaao]

Attempt at fixing #13766

Combined parallel and sync process spawning since parallel one was already dealing with capturing signals, so it seemed like the easiest way to fix it

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
nx-dev	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Mar 17, 2023 at 3:00PM (UTC)

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit dcf0735. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

⌛ The following targets are in progress

• nx affected --target=build --base=a52e60910108149e13f241d9c0a47ad16fd5d134 --head=616f0f0617e83fbed94b7a11e72ad90de0a263de --parallel=3
• nx affected --target=test --base=a52e60910108149e13f241d9c0a47ad16fd5d134 --head=616f0f0617e83fbed94b7a11e72ad90de0a263de --parallel=1

✅ Successfully ran 6 targets

• nx run-many -t root-lint check-imports check-commit check-lock-files depcheck --parallel=1 --no-dte
• nx affected --target=lint --base=a52e60910108149e13f241d9c0a47ad16fd5d134 --head=616f0f0617e83fbed94b7a11e72ad90de0a263de --parallel=3
• nx-cloud record -- nx format:check --base=a52e60910108149e13f241d9c0a47ad16fd5d134 --head=616f0f0617e83fbed94b7a11e72ad90de0a263de
• nx documentation --no-dte
• nx affected --target=e2e --base=a52e60910108149e13f241d9c0a47ad16fd5d134 --head=b1be092bd4b802b4d4053d49e97ae2e2df9d9938 --exclude=e2e-storybook,e2e-storybook-angular --parallel=1
• nx run-many -t e2e-macos --parallel=1 --exclude=e2e-detox

---

Sent with 💌 from NxCloud.

[luxaritas]

Is this also related to (or even fixes) #11782? Maybe it needs to be expanded to run-script as well?

[caioaao]

@luxaritas this fixes the run-commands executor, but I didn't check how the run-script executor is related

[AgentEnder]

This looks like a good change, but there are some weird formatting issues. I'll reformat it and address the minor comment I had, but this should be merged later today :)

[AgentEnder]

Lets reuse the childProcessExitListener here

[AgentEnder]

Huh, on second glance I don't have permission to push up to the branch on your fork. Can you run nx format after addressing the minor comment?

[luxaritas]

Any chance we can get run-script addressed now as well?

[caioaao]

@AgentEnder oh that's weird. I thought contributors had push access to forks. Will do!

[caioaao]

@luxaritas I'm currently traveling, so I don't think I'll have time for going through run-scripts too. I might have time after Jan 23rd though

[caioaao]

@AgentEnder thanks for fixing tests and pushing this over the finish line! Let me know if there are any pending changes that you need help with. I'm now back so I can spend some time on it

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.