-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(testing): warn and default if sourceRoot isn't set for ng CT #13940
Merged
barbados-clemens
merged 1 commit into
nrwl:master
from
barbados-clemens:fix/ng-ct-source-root
Dec 21, 2022
Merged
fix(testing): warn and default if sourceRoot isn't set for ng CT #13940
barbados-clemens
merged 1 commit into
nrwl:master
from
barbados-clemens:fix/ng-ct-source-root
Dec 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barbados-clemens
added
the
scope: testing tools
Issues related to Cypress / Jest / Playwright / Vitest support in Nx
label
Dec 20, 2022
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
barbados-clemens
force-pushed
the
fix/ng-ct-source-root
branch
from
December 20, 2022 22:25
80ae49a
to
ac94579
Compare
Coly010
approved these changes
Dec 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I left a minor comment about the warning
barbados-clemens
force-pushed
the
fix/ng-ct-source-root
branch
from
December 21, 2022 17:36
ac94579
to
00fecff
Compare
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
when sourceRoot is missing in the project.json angular CT errors out trying to join the paths
Expected Behavior
does not error or provides helpful error
Related Issue(s)
Fixes #13883