fix(testing): correctly set task status for failed coverage reports

[barbados-clemens]

Current Behavior

when coverage isn't met vitest shows error but nx says it was successful

Expected Behavior

not met coverage limits should cause tasks to fail

Related Issue(s)

Also noticed an incosistency with the coverage paths set by the vitest generator.

basically using the {workspaceRoot} and {projectRoot} variables in the executor options which are not currently expanded so the folder structure results in the actual test {workspaceRoot} as the folder names.

Also by default coverage reports are placed in the project root (where vitest runs). Should this line up with jest and be in the root /coverage/ directory?

I initially thought so based on the standalone project (since project root is also the workspace root) but noticed in integrated repo it's actually the project root. Open to whatever makes sense just wanted to fix the paths but need to know where they should be for the generator and migration

Fixes #13676

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Updated
nx-dev	⬜️ Ignored (Inspect)		Dec 28, 2022 at 9:01PM (UTC)

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 08ea6f6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 21 targets

• nx affected --target=e2e --base=181cde50975cf53364f7c2599c01dcb2e315700f --head=08ea6f686d2e4ea0903b43c569d2ce71efa12c86 --exclude=e2e-storybook,e2e-storybook-angular,e2e-react-native,e2e-detox --parallel=1
• nx affected --target=test --base=181cde50975cf53364f7c2599c01dcb2e315700f --head=08ea6f686d2e4ea0903b43c569d2ce71efa12c86 --parallel=1
• nx affected --target=build --base=181cde50975cf53364f7c2599c01dcb2e315700f --head=08ea6f686d2e4ea0903b43c569d2ce71efa12c86 --parallel=3
• nx depcheck --no-dte
• nx lint --no-dte
• nx check-lock-files --no-dte
• nx affected --target=lint --base=181cde50975cf53364f7c2599c01dcb2e315700f --head=08ea6f686d2e4ea0903b43c569d2ce71efa12c86 --parallel=3
• nx check-commit --no-dte
• nx-cloud record -- nx format:check --base=181cde50975cf53364f7c2599c01dcb2e315700f --head=08ea6f686d2e4ea0903b43c569d2ce71efa12c86
• nx check-imports --no-dte
• nx documentation --no-dte
• nx depcheck --no-dte
• nx affected --target=build --base=181cde50975cf53364f7c2599c01dcb2e315700f --head=6dcf20eae5dc93e0e89b523a805691ea4ef240ae --parallel=3
• nx lint --no-dte
• nx check-lock-files --no-dte
• nx affected --target=lint --base=181cde50975cf53364f7c2599c01dcb2e315700f --head=6dcf20eae5dc93e0e89b523a805691ea4ef240ae --parallel=3
• nx check-commit --no-dte
• nx affected --target=test --base=181cde50975cf53364f7c2599c01dcb2e315700f --head=6dcf20eae5dc93e0e89b523a805691ea4ef240ae --parallel=1
• nx-cloud record -- nx format:check --base=181cde50975cf53364f7c2599c01dcb2e315700f --head=6dcf20eae5dc93e0e89b523a805691ea4ef240ae
• nx check-imports --no-dte
• nx documentation --no-dte

---

Sent with 💌 from NxCloud.

[AgentEnder]

IMHO they should line up with paths from other executor options, which tend to be based on workspace root

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.