Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bundling): add option to esbuild to not bundle #14145

Merged
merged 1 commit into from
Jan 4, 2023

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Jan 4, 2023

This PR adds bundle: false support for esbuild. When bundle is off, the behavior is the same as tsc and swc, where include and exclude from corresponding tsconfig file determines what files are transpiled.

Current Behavior

nx build --bundle=false does not work

Expected Behavior

nx build --bundle=false results in multiple transpiled files

Related Issue(s)

Fixes #13997

@vercel
Copy link

vercel bot commented Jan 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview Jan 4, 2023 at 6:27PM (UTC)

@jaysoo jaysoo merged commit bd14b24 into nrwl:master Jan 4, 2023
@jaysoo jaysoo deleted the issues/13997 branch January 4, 2023 18:36
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@nrwl/esbuild ignoring bundle key when is set to false for .mjs
2 participants