fix(react): fix skipRemotes in moduleFederationDevServer

[Ronaldo-Maciel]

option skipRemotes isn't working when use array multidimensional in moduleFederationConfig

Current Behavior

When using multidimensional array in the remotes option in module-federation-config.js it makes the skipRemotes option not work when putting the names of the applications to be ignored.

Example:

// module-federation.config.js
 const moduleFederationConfig = {
  name: 'admin',
  remotes: [
    ['gallery-admin', 'http://localhost:8000/v1/static/galleries/remoteEntry.js'],
    ['other-admin', 'http://localhost:8000/v1/static/ola/remoteEntry.js'],
  ],
}

// project.json
{ "skipRemotes": ["other-admin"] }

When run the command yarn nx run admin:serve the application in the skip config continues to be triggered

Expected Behavior

When run the command yarn nx run admin:serve the application in the skip config should not be triggered

Related Issue(s)

Fixes #

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated
nx-dev	⬜️ Ignored (Inspect)			Feb 21, 2023 at 3:03PM (UTC)

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 5f4f691. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 8 targets

• nx run-many -t e2e-macos --parallel=1 --exclude=e2e-detox
• nx affected --target=e2e --base=ba901866281592e61340e8921be88e715189c259 --head=5f4f691ef4fe2007ef1a0f1234ef885fd7e9a827 --exclude=e2e-storybook,e2e-storybook-angular --parallel=1
• nx affected --target=test --base=ba901866281592e61340e8921be88e715189c259 --head=5f4f691ef4fe2007ef1a0f1234ef885fd7e9a827 --parallel=1
• nx run-many -t root-lint check-imports check-commit check-lock-files depcheck --parallel=1 --no-dte
• nx affected --target=build --base=ba901866281592e61340e8921be88e715189c259 --head=5f4f691ef4fe2007ef1a0f1234ef885fd7e9a827 --parallel=3
• nx affected --target=lint --base=ba901866281592e61340e8921be88e715189c259 --head=5f4f691ef4fe2007ef1a0f1234ef885fd7e9a827 --parallel=3
• nx-cloud record -- nx format:check --base=ba901866281592e61340e8921be88e715189c259 --head=5f4f691ef4fe2007ef1a0f1234ef885fd7e9a827
• nx documentation --no-dte

---

Sent with 💌 from NxCloud.

[Coly010]

Thanks for submitting a PR 🎉 but it might have been worth raising an issue first to see if we could discuss your problem.

can you tell me more about what you tried to do to use skipRemotes that wasn’t working for you?

Module Federation dev Server should already support skipRemotes

[Coly010]

Actually, I can see the problem. Let me take a look 😁

[AnerRiskified]

any news regarding this issue?
its blocking the possibility of using an external remote

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.