-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(react): fix skipRemotes in moduleFederationDevServer #14172
fix(react): fix skipRemotes in moduleFederationDevServer #14172
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Thanks for submitting a PR 🎉 but it might have been worth raising an issue first to see if we could discuss your problem. can you tell me more about what you tried to do to use skipRemotes that wasn’t working for you? Module Federation dev Server should already support skipRemotes |
Actually, I can see the problem. Let me take a look 😁 |
any news regarding this issue? |
option skipRemotes isn't working when use array multidimensional in moduleFederationConfig
9bde72a
to
5f4f691
Compare
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
option skipRemotes isn't working when use array multidimensional in moduleFederationConfig
Current Behavior
When using multidimensional array in the remotes option in module-federation-config.js it makes the skipRemotes option not work when putting the names of the applications to be ignored.
Example:
When run the command
yarn nx run admin:serve
the application in the skip config continues to be triggeredExpected Behavior
When run the command
yarn nx run admin:serve
the application in the skip config should not be triggeredRelated Issue(s)
Fixes #