feat(misc): move ci options to configuration

[DaSchTour]

make test task depend less on jest specific options and use configuration instead to be more inclusive

ISSUES CLOSED: #12045

Current Behavior

Documentation suggests to add flags --ci and --code-coverage to tasks. This is specific for jest and might break with other tests.

Expected Behavior

To have a jest independent approach we might start with using configurations instead of specific flags.

Related Issue(s)

This would also allow preventing issues like #12045 and allow to run karma and jest test within one target.

Fixes #12045

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
nx-dev	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Jan 21, 2023 at 1:39PM (UTC)

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit face364. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

⌛ The following target is in progress

• nx affected --target=e2e --base=c6adec7f9d9536eee9507cdc38a0209af69dce02 --head=45230d241cc92af553cadd1ff73c843913a8afba --exclude=e2e-storybook,e2e-storybook-angular --parallel=1

🟥 Failed Commands
nx affected --target=test --base=c6adec7f9d9536eee9507cdc38a0209af69dce02 --head=45230d241cc92af553cadd1ff73c843913a8afba --parallel=1

✅ Successfully ran 12 targets

• nx run-many -t e2e-macos --parallel=1 --exclude=e2e-detox
• nx affected --target=e2e --base=c6adec7f9d9536eee9507cdc38a0209af69dce02 --head=face364d3a881cc8d37e8959809aba0aefd14499 --exclude=e2e-storybook,e2e-storybook-angular --parallel=1
• nx affected --target=test --base=c6adec7f9d9536eee9507cdc38a0209af69dce02 --head=face364d3a881cc8d37e8959809aba0aefd14499 --parallel=1
• nx run-many -t root-lint check-imports check-commit check-lock-files depcheck documentation --parallel=1 --no-dte
• nx affected --target=lint --base=c6adec7f9d9536eee9507cdc38a0209af69dce02 --head=face364d3a881cc8d37e8959809aba0aefd14499 --parallel=3
• nx affected --target=build --base=c6adec7f9d9536eee9507cdc38a0209af69dce02 --head=face364d3a881cc8d37e8959809aba0aefd14499 --parallel=3
• nx-cloud record -- nx format:check --base=c6adec7f9d9536eee9507cdc38a0209af69dce02 --head=face364d3a881cc8d37e8959809aba0aefd14499
• nx run-many -t e2e-macos --parallel=1 --exclude=e2e-detox
• nx run-many -t root-lint check-imports check-commit check-lock-files depcheck documentation --parallel=1 --no-dte
• nx affected --target=build --base=c6adec7f9d9536eee9507cdc38a0209af69dce02 --head=45230d241cc92af553cadd1ff73c843913a8afba --parallel=3
• nx affected --target=lint --base=c6adec7f9d9536eee9507cdc38a0209af69dce02 --head=45230d241cc92af553cadd1ff73c843913a8afba --parallel=3
• nx-cloud record -- nx format:check --base=c6adec7f9d9536eee9507cdc38a0209af69dce02 --head=45230d241cc92af553cadd1ff73c843913a8afba

---

Sent with 💌 from NxCloud.

[AgentEnder]

Changes make sense, can you fix the failing tests? CC @barbados-clemens, you see any issue w/ this?

[barbados-clemens]

CC @barbados-clemens, you see any issue w/ this?

Personally, I don't care much for code coverage being in the CI configuration, but I can be convinced since most people probably do end up use code coverage for CI and it helps reenforce the idea of nx configurations instead of just passing args all the time.

[DaSchTour]

I haven't worked with jest snapshots before. That's why the test were failing. Should be updated now.

[barbados-clemens]

Looks like angular, nest, node, and nx-plugin are still out of date. they might be using .toEqual() instead of snapshots which is why they didn't get updated.

Using the Nx Cloud link you can see the failing tests. Or you can just run nx affected --target=test to see them locally.

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.