feat(angular): remove decorate-angular-cli #14226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Coly010
force-pushed
the
angular/remove-decorate-cli
branch
from
07918bb
to
2a45d4e
Compare
AgentEnder
reviewed
Jan 9, 2023
| @@ -129,12 +129,11 @@ describe('convert Angular CLI workspace to an Nx workspace', () => { | |||
| const updatedPackageJson = readJson('package.json'); | |||
| expect(updatedPackageJson.description).toEqual('some description'); | |||
| expect(updatedPackageJson.scripts).toEqual({ | |||
| ng: 'nx', | |||
There was a problem hiding this comment.
Should we instead change this to something like 'nx': 'nx' or simply remove it?
There was a problem hiding this comment.
Yeah I'm not too certain!
There was a problem hiding this comment.
This is from what @angular/cli generates?
I think we should leave it alone.
AgentEnder
approved these changes
Jan 9, 2023
FrozenPandaz
approved these changes
Jan 9, 2023
| @@ -129,12 +129,11 @@ describe('convert Angular CLI workspace to an Nx workspace', () => { | |||
| const updatedPackageJson = readJson('package.json'); | |||
| expect(updatedPackageJson.description).toEqual('some description'); | |||
| expect(updatedPackageJson.scripts).toEqual({ | |||
| ng: 'nx', | |||
There was a problem hiding this comment.
This is from what @angular/cli generates?
I think we should leave it alone.
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
We currently decorate the angular cli so that all
ngcommands get piped tonx.Expected Behavior
We want Nx to be seen and used as a standalone CLI tool, therefore remove the linking between angular cli + nx