Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): remove hard dependencies to @nrwl/vite and @nrwl/webpack #14408

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Jan 16, 2023

Currently @nrwl/web has dependencies on @nrwl/vite and @nrwl/webpack. This is not correct, and those plugins should be installed as needed by the generators.

@vercel
Copy link

vercel bot commented Jan 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
nx-dev ⬜️ Ignored (Inspect) Jan 16, 2023 at 8:37PM (UTC)

@jaysoo jaysoo force-pushed the fix/remove-vite-dep-from-web branch from 7e4e6e3 to 870e0ad Compare January 16, 2023 20:36
@jaysoo jaysoo merged commit e0bd338 into nrwl:master Jan 17, 2023
@jaysoo jaysoo deleted the fix/remove-vite-dep-from-web branch January 17, 2023 13:05
FrozenPandaz pushed a commit that referenced this pull request Jan 17, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants