-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): move tsconfig.base.json to @nrwl/js:init #14467
feat(core): move tsconfig.base.json to @nrwl/js:init #14467
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
4c75e53
to
cfef715
Compare
cfef715
to
8593277
Compare
8593277
to
7edb2ac
Compare
4039515
to
b37dac2
Compare
b37dac2
to
87190a9
Compare
87190a9
to
b0fac00
Compare
b0fac00
to
a604fb6
Compare
a604fb6
to
491c32d
Compare
491c32d
to
329981c
Compare
329981c
to
e5bed8c
Compare
e5bed8c
to
99f982f
Compare
packages/angular/src/generators/application/angular-v14/lib/update-config-files.ts
Outdated
Show resolved
Hide resolved
packages/workspace/src/generators/new/generate-workspace-files.ts
Outdated
Show resolved
Hide resolved
99f982f
to
54d64a6
Compare
3bf41ba
to
a403201
Compare
a403201
to
b7339b3
Compare
@@ -132,7 +132,8 @@ export async function configurationGenerator( | |||
} | |||
} | |||
|
|||
const initTask = initGenerator(tree, { | |||
const initTask = await initGenerator(tree, { | |||
js: schema.js, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not be here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this js passed to initGenerator is just to determine whether the typescript package needs to be installed or not. it does not create any files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand, but I think it would be cleaner for it not to be here... If you think it's better to be there rather than configuration
generator, then ok...
b7339b3
to
68579e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good 😄
packages/angular/src/generators/application/angular-v14/lib/add-unit-test-runner.ts
Outdated
Show resolved
Hide resolved
@@ -19,12 +19,13 @@ import { | |||
writeJson, | |||
} from '@nrwl/devkit'; | |||
import { getImportPath } from 'nx/src/utils/path'; | |||
import { Linter, lintProjectGenerator } from '@nrwl/linter'; | |||
// nx-ignore-next-line | |||
const { Linter } = require('@nrwl/linter'); // use require to import to avoid circular dependency |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a type? Or should it be lower down after the ensurePackage('@nrwl/linter')
is called?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not a type. moved it down.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am approving, but leaving my comments, too! :D
@@ -132,7 +132,8 @@ export async function configurationGenerator( | |||
} | |||
} | |||
|
|||
const initTask = initGenerator(tree, { | |||
const initTask = await initGenerator(tree, { | |||
js: schema.js, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand, but I think it would be cleaner for it not to be here... If you think it's better to be there rather than configuration
generator, then ok...
@@ -210,7 +212,11 @@ function editRootTsConfig(tree: Tree) { | |||
} | |||
} | |||
|
|||
export function initGenerator(tree: Tree, schema: Schema) { | |||
export async function initGenerator(tree: Tree, schema: Schema) { | |||
await jsInitGenerator(tree, { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see. But someone may call the init generator and not call the configuration generator at all, so they would not need the js
... But again, if you think it makes sense here, then ok!
68579e8
to
f9992a4
Compare
f9992a4
to
0fb0ef5
Compare
feat(core): move tsconfig.base.json to @nrwl/js:init
0fb0ef5
to
f9504bf
Compare
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
import * as ts from 'typescript';
in the code; however for package based repo, typescript is not installed initially; so i move utils functions from packages/workspace/src/utilities/typescript.ts to packages/workspace/src/utilities/ts-config.tsCurrent Behavior
Expected Behavior
Related Issue(s)
Fixes #