feat(core): hide hidden and deprecated generators from prompts #14561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
AgentEnder
force-pushed
the
feat/hide-deprecateed-generators
branch
from
d6ad08e
to
08d6bbe
Compare
FrozenPandaz
requested changes
Jan 24, 2023
AgentEnder
force-pushed
the
feat/hide-deprecateed-generators
branch
from
482a731
to
4890a35
Compare
AgentEnder
force-pushed
the
feat/hide-deprecateed-generators
branch
from
4890a35
to
e6ffc20
Compare
FrozenPandaz
approved these changes
Jan 27, 2023
| @@ -145,6 +169,13 @@ async function promptForCollection( | |||
| return customCollection | |||
| ? `${customCollection}:${generatorName}` | |||
| : generator; | |||
| } else if (deprecatedChoices.size > 0) { | |||
| throw new Error( | |||
There was a problem hiding this comment.
Let's do this:
- Warn them there are no non-deprecated
- Let them choose which deprecated one they want
- Run it
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Plugin authors have no way to mark existing generators as deprecated, and provide information to help folks transition to newer means.
Expected Behavior
Related Issue(s)
Fixes #