Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): install @nrwl/web when module federation is used #14660

Merged
merged 1 commit into from
Jan 27, 2023

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Jan 27, 2023

Module federation for React uses @nrwl/web:file-server to statically serve remote apps. Now that @nrwl/react no longer has a hard dependency on the web plugin, we need to install it when using @nrwl/react:host or @nrwl/react:remote generators.

Current Behavior

Expected Behavior

Related Issue(s)

Related #14629

@vercel
Copy link

vercel bot commented Jan 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
nx-dev ⬜️ Ignored (Inspect) Jan 27, 2023 at 1:17PM (UTC)

@jaysoo jaysoo requested a review from mandarini January 27, 2023 13:26
@mandarini mandarini merged commit 8bebf33 into nrwl:master Jan 27, 2023
FrozenPandaz pushed a commit that referenced this pull request Jan 27, 2023
@github-actions
Copy link

github-actions bot commented Mar 5, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants