Add @nrwl/workspace does not update stylePreprocessorOptions.includePaths

[jonrimmer]

Expected Behavior

When I use ng add @nrwl/workspace, my app's sources are moved into ./apps. All the paths in angular.json should be updated to reflect this.

Current Behavior

If my project is using the build.options.stylePreprocessorOptions.includePaths config, this does not get updated. E.g.

  "build": {
    "options": {
      "stylePreprocessorOptions": {
        "includePaths": [ "src/assets/styles" ]
      }
    }
  }

This include path is left alone by the add schematic.

Failure Information (for bugs)

After running ng app @nrwl/workspace, the include path should be updated to apps/{appName}/src/assets/styles.

Steps to Reproduce

Please provide detailed steps for reproducing the issue.

1. ng new nx-test
2. Edit angular.json and add a style include path referening ./src or a subpath of it.
3. ng add @nrwl/workspace

Context

Nx: 8.1.0.
Angular CLI: 8

[FrozenPandaz]

Thank you for reporting this. If someone from the community would like to work on this, the code is here:

https://github.com/nrwl/nx/blob/master/packages/workspace/src/schematics/ng-add/ng-add.ts#L117

[matheo]

@FrozenPandaz I migrated a CLI project recently (after upgrading it to Angular 8) and I fixed many issues that I had in the process. I built the workspace package locally and fixed it step by step until I got my app updated. I've opened #1476 including this path update.

@jonrimmer it would be nice if you build my PR locally (yarn install and yarn build) and link or copy the resulting package (at dist/packages/workspace) to replace the @nrwl/workspace of your project, and run ng add @nrwl/workspace with it to see if your project gets some new tsconfigs for your app after that, and the styles path fixed of course!

[jonr-elsewhen]

@matheo Tried it, but It does not work.

Problem seems to be this line: matheo@227ba7e#diff-a9ea54d30f3a734ae12a67708517088cR394

You are trying to rename the app's tsConfig—e.g. src/tsconfig.app.json—to tsconfig.json. This will fail if there is already a tsConfig.json in the project root, which there almost always is, as it is this file that tsconfig.app.json and tsconfig.spec.json usually extend.

[matheo]

@jonr-elsewhen hmm, I will fix that, my old CLI project had only one tsconfig 👍

[mehrad-rafigh]

@matheo Any progress on this?

[matheo]

@mehrad-rafigh perhaps you can help me to finish this.
I haven't the time to figure the different scenarios and its configurations,
with a clear picture I may finish this :)

[github-actions]

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.