Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix project locator for built in node modules #14846

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

FrozenPandaz
Copy link
Collaborator

Current Behavior

Imports from built in node modules like path, fs, etc. will resolve to the root project which is incorrect.

Expected Behavior

Imports from built in node modules like path, fs, etc. will resolve to null.

Related Issue(s)

Fixes #14571

@vercel
Copy link

vercel bot commented Feb 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 7, 2023 at 3:52PM (UTC)

@github-actions
Copy link

github-actions bot commented Mar 3, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Having nx key in package.json breaks "enforce-module-boundaries" linting
3 participants