Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): set project root when reading project.json in the adapter scoped host #14849

Merged

Conversation

leosvelperez
Copy link
Member

Current Behavior

The Angular CLI adapter is not setting the project root property when reading the config. When running Angular DevKit builders the Angular DevKit warns in Angular 14 and throws in Angular 15. The compat swallows the error in the latter case and fallback to reading the config differently (still not ideal, but there's no apparent issue for the users), but when using Angular 14 the warnings are logged out causing noise.

Expected Behavior

The Angular CLI adapter should set the project root property when reading the config. No error or warning should be thrown or logged by the Angular DevKit because of a missing root property.

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Feb 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 7, 2023 at 6:13PM (UTC)

@leosvelperez leosvelperez enabled auto-merge (squash) February 7, 2023 18:45
@leosvelperez leosvelperez merged commit b736d1f into nrwl:master Feb 7, 2023
@leosvelperez leosvelperez deleted the angular/ng-cli-adapter-project-root branch February 7, 2023 18:59
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants