fix(devkit): make devkit backwards compatible back to nx 14.1 #14854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 37994ea. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
FrozenPandaz
force-pushed
the
fix-devkit-imports
branch
from
b219c8e
to
7b4842c
Compare
FrozenPandaz
requested review from
AgentEnder,
vsavkin,
jaysoo,
Coly010,
mandarini,
nartc and
ndcunningham
as code owners
AgentEnder
approved these changes
Feb 8, 2023
nartc
approved these changes
Feb 8, 2023
FrozenPandaz
force-pushed
the
fix-devkit-imports
branch
from
7b4842c
to
8511be6
Compare
FrozenPandaz
force-pushed
the
fix-devkit-imports
branch
4 times, most recently
from
3b5ffe9
to
74b2ef9
Compare
isaacplmann
approved these changes
Feb 8, 2023
FrozenPandaz
force-pushed
the
fix-devkit-imports
branch
from
74b2ef9
to
0b56a32
Compare
FrozenPandaz
force-pushed
the
fix-devkit-imports
branch
from
0b56a32
to
781531a
Compare
jaysoo
approved these changes
Feb 8, 2023
FrozenPandaz
force-pushed
the
fix-devkit-imports
branch
from
781531a
to
6d2b75e
Compare
FrozenPandaz
force-pushed
the
fix-devkit-imports
branch
from
6d2b75e
to
ea442c2
Compare
FrozenPandaz
force-pushed
the
fix-devkit-imports
branch
from
ea442c2
to
ffe1e10
Compare
Coly010
approved these changes
Feb 9, 2023
| dependencies: { '@angular/core': '~13.2.0' }, | ||
| })); | ||
| jest.spyOn(nxFileutils, 'readJsonFile').mockImplementation((file) => { | ||
| console.log('HELLO?'); |
mandarini
approved these changes
Feb 9, 2023
FrozenPandaz
force-pushed
the
fix-devkit-imports
branch
from
ffe1e10
to
37994ea
Compare
xiongemi
approved these changes
Feb 9, 2023
AgentEnder
approved these changes
Feb 9, 2023
| "patterns": [ | ||
| { | ||
| "group": ["nx/**/*"], | ||
| "message": "Use getNx() from packages/devkit/nx.ts OR use a type import instead.", |
There was a problem hiding this comment.
Suggested change
| "message": "Use getNx() from packages/devkit/nx.ts OR use a type import instead.", | |
| "message": "Use requireNx() from packages/devkit/nx.ts OR use a type import instead.", |
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
@nrwl/devkit is supposed to be backwards compatible back to Nx 14 but currently fails if you have something like.
This makes it harder for plugin owners to maintain backwards compatibility for older versions of Nx while keeping up with the latest
@nrwl/devkitExpected Behavior
The following should always work.
There's a
nx/src/devkit-exportsandnx/src/devkit-testing-exportsfile which exports things to devkit.In v17, @nrwl/devkit will only import from nx using path. This will make the compatibility more robust in the future.
To facilitate this, when importing nx from @nrwl/devkit, we should use
requireNx()until v17.Related Issue(s)
Fixes #