Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(angular): ensure peer deps are installed when initializing the plugin #14906

Merged
merged 1 commit into from
Feb 14, 2023
Merged

fix(angular): ensure peer deps are installed when initializing the plugin #14906

merged 1 commit into from
Feb 14, 2023

Conversation

xiongemi
Copy link
Collaborator

@xiongemi xiongemi commented Feb 9, 2023

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Feb 9, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 14, 2023 at 2:09PM (UTC)

@nx-cloud
Copy link

nx-cloud bot commented Feb 9, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit de7fb53. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 8 targets

Sent with 💌 from NxCloud.

@xiongemi xiongemi force-pushed the feat/angular-make-it-work-without-peer-deps branch from 0436bbd to 0c7ba04 Compare February 9, 2023 20:47
@xiongemi xiongemi force-pushed the feat/angular-make-it-work-without-peer-deps branch from 0c7ba04 to edd2f76 Compare February 9, 2023 21:55
@xiongemi xiongemi marked this pull request as ready for review February 9, 2023 23:20
@xiongemi xiongemi force-pushed the feat/angular-make-it-work-without-peer-deps branch from edd2f76 to 07c8092 Compare February 10, 2023 03:39
barbados-clemens
barbados-clemens approved these changes Feb 10, 2023
View reviewed changes
Copy link
Contributor

@barbados-clemens barbados-clemens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine from the jest/cypress side

@xiongemi xiongemi closed this Feb 10, 2023
@FrozenPandaz FrozenPandaz reopened this Feb 13, 2023
@leosvelperez leosvelperez self-assigned this Feb 13, 2023
@leosvelperez leosvelperez marked this pull request as draft February 14, 2023 11:58
@leosvelperez leosvelperez changed the title feat(angular): change to not pre-install peer deps for angular fix(angular): ensure peer deps are installed when initializing the plugin Feb 14, 2023
@leosvelperez leosvelperez force-pushed the feat/angular-make-it-work-without-peer-deps branch from 07c8092 to 85a8688 Compare February 14, 2023 12:21
@leosvelperez leosvelperez self-requested a review February 14, 2023 12:22
@leosvelperez leosvelperez marked this pull request as ready for review February 14, 2023 13:57
@leosvelperez leosvelperez force-pushed the feat/angular-make-it-work-without-peer-deps branch from 85a8688 to de7fb53 Compare February 14, 2023 14:06
AgentEnder
AgentEnder approved these changes Feb 14, 2023
View reviewed changes
Copy link
Member

@AgentEnder AgentEnder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

packages/workspace and e2e/nx-misc LGTM

@FrozenPandaz FrozenPandaz merged commit 032efc2 into master Feb 14, 2023
@FrozenPandaz FrozenPandaz deleted the feat/angular-make-it-work-without-peer-deps branch February 14, 2023 16:07
FrozenPandaz pushed a commit that referenced this pull request Feb 15, 2023
@xiongemi @FrozenPandaz
fix(angular): ensure peer deps are installed when initializing the pl…
27e43d0 
…ugin (#14906)

Co-authored-by: Leosvel Pérez Espinosa <leosvel.perez.espinosa@gmail.com>
(cherry picked from commit 032efc2)
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AgentEnder AgentEnder AgentEnder approved these changes

@FrozenPandaz FrozenPandaz FrozenPandaz approved these changes

@leosvelperez leosvelperez leosvelperez approved these changes

@barbados-clemens barbados-clemens barbados-clemens approved these changes

@nartc nartc nartc approved these changes

@meeroslav meeroslav Awaiting requested review from meeroslav meeroslav is a code owner

@vsavkin vsavkin Awaiting requested review from vsavkin vsavkin is a code owner

@Coly010 Coly010 Awaiting requested review from Coly010

@ndcunningham ndcunningham Awaiting requested review from ndcunningham

@jaysoo jaysoo Awaiting requested review from jaysoo jaysoo is a code owner

Assignees

@leosvelperez leosvelperez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@xiongemi @AgentEnder @FrozenPandaz @leosvelperez @barbados-clemens @nartc